linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/3] gpio: generic: replace devm_request_mem_region / devm_ioremap with devm_ioremap_resource
@ 2015-09-30 21:51 Heiner Kallweit
  2015-10-05  7:15 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2015-09-30 21:51 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-gpio

Replace devm_request_mem_region / devm_ioremap with devm_ioremap_resource.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/gpio/gpio-generic.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
index eefff1a..0cdbe10 100644
--- a/drivers/gpio/gpio-generic.c
+++ b/drivers/gpio/gpio-generic.c
@@ -582,9 +582,7 @@ static void __iomem *bgpio_map(struct platform_device *pdev,
 			       resource_size_t sane_sz,
 			       int *err)
 {
-	struct device *dev = &pdev->dev;
 	struct resource *r;
-	resource_size_t start;
 	resource_size_t sz;
 	void __iomem *ret;
 
@@ -602,15 +600,9 @@ static void __iomem *bgpio_map(struct platform_device *pdev,
 		return NULL;
 	}
 
-	start = r->start;
-	if (!devm_request_mem_region(dev, start, sz, r->name)) {
-		*err = -EBUSY;
-		return NULL;
-	}
-
-	ret = devm_ioremap(dev, start, sz);
-	if (!ret) {
-		*err = -ENOMEM;
+	ret = devm_ioremap_resource(&pdev->dev, r);
+	if (IS_ERR(ret)) {
+		*err = PTR_ERR(ret);
 		return NULL;
 	}
 
-- 
2.6.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/3] gpio: generic: replace devm_request_mem_region / devm_ioremap with devm_ioremap_resource
  2015-09-30 21:51 [PATCH 2/3] gpio: generic: replace devm_request_mem_region / devm_ioremap with devm_ioremap_resource Heiner Kallweit
@ 2015-10-05  7:15 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2015-10-05  7:15 UTC (permalink / raw)
  To: Heiner Kallweit; +Cc: linux-gpio@vger.kernel.org

On Wed, Sep 30, 2015 at 11:51 PM, Heiner Kallweit <hkallweit1@gmail.com> wrote:

> Replace devm_request_mem_region / devm_ioremap with devm_ioremap_resource.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Edited the too long subject and applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-05  7:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-30 21:51 [PATCH 2/3] gpio: generic: replace devm_request_mem_region / devm_ioremap with devm_ioremap_resource Heiner Kallweit
2015-10-05  7:15 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).