From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Thomas Hebb <tommyhebb@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Antoine Tenart <antoine.tenart@free-electrons.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] pinctrl: berlin: fix BG2CD field widths
Date: Mon, 05 Oct 2015 20:07:45 +0200 [thread overview]
Message-ID: <5612BC71.1060807@gmail.com> (raw)
In-Reply-To: <CACRpkdZ9HJtmEs6KhFRwh4=i2kOqeKV_WPDoi5zppNBc2FUDFw@mail.gmail.com>
On 05.10.2015 09:24, Linus Walleij wrote:
> On Thu, Oct 1, 2015 at 9:30 PM, Sebastian Hesselbarth
> <sebastian.hesselbarth@gmail.com> wrote:
>> On 27.09.2015 03:03, Thomas Hebb wrote:
>>>
>>> The previous register layout was incorrect, many of the fields having
>>> fewer bits than were needed to represent all their modes. The new layout
>>> is taken from the bootloader source of a BG2CD device.
>>>
>>> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
>>> ---
>>> drivers/pinctrl/berlin/berlin-bg2cd.c | 62
>>> ++++++++++++++++++-----------------
>>> 1 file changed, 32 insertions(+), 30 deletions(-)
>>
>>
>> Applied to berlin/fixes.
>>
>> There seems to be something wrong with the patch.
>> Please base your patches on the recent -rc1 kernel
>> and use git send-email. I fixed this patch manually.
>
> I don't understand. Is this for the upstream kernel or not?
>
> I should take it into the pinctrl tree if you ACK it I think?
Linus,
sorry, of course it is up to you to take it. I haven't sent a
PR for the branch I precipitately applied this patch to.
As the patch has issues with latest -rc1 I can provide you
a -rc1 compatible version of it. You can also pull it from
my branch if you prefer.
Please let me know you want the patch and sorry again for
the confusion.
Sebastian
next prev parent reply other threads:[~2015-10-05 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 1:03 [PATCH] pinctrl: berlin: fix BG2CD field widths Thomas Hebb
2015-10-01 19:30 ` Sebastian Hesselbarth
2015-10-05 7:24 ` Linus Walleij
2015-10-05 18:07 ` Sebastian Hesselbarth [this message]
2015-10-06 7:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5612BC71.1060807@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=antoine.tenart@free-electrons.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tommyhebb@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).