From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Tony Lindgren <tony@atomide.com>,
Austin Schuh <austin@peloton-tech.com>,
Santosh Shilimkar <ssantosh@kernel.org>
Subject: Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate
Date: Wed, 7 Oct 2015 14:19:00 -0500 [thread overview]
Message-ID: <56157024.1070905@ti.com> (raw)
In-Reply-To: <20151007072743.GB21158@sudip-pc>
On 10/07/2015 02:27 AM, Sudip Mukherjee wrote:
> On Tue, Oct 06, 2015 at 03:45:07PM -0500, Grygorii Strashko wrote:
>> On 10/06/2015 07:01 AM, Sudip Mukherjee wrote:
>>> While building arm allmodconfig the build fails with the error:
>>> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
>>>
>>> The build breaks as handle_bad_irq is not exported for module use.
>>
>> Not sure if this is right thing to do. We really want it to be a module if needed.
>>
>> The handle_bad_irq() was used in this driver to catch the case when Omap
>> GPIO IRQ is enabled before calling .irq_set_type()
>>
>> I think there are few option:
>> - export handle_bad_irq()
>> - pass NULL in gpiochip_irqchip_add() instead of handle_bad_irq()
>> - use handle_simple_irq()
>> - revert this change
>>
>> Thought second one should work.
>
> I think that should be ok. If you want me to test the patch in my setup
> to verify that it fixes the build failure please let me know.
>
> But going through the old thread it looked like plan was on to
> export handle_bad_irq() atleast thats what looks like from Linus's
> (Linus Walleij) reply in https://lkml.org/lkml/2014/2/25/119
There is patch from Arnd which implements option one.
https://lkml.org/lkml/2015/10/6/836
--
regards,
-grygorii
next prev parent reply other threads:[~2015-10-07 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 12:01 [PATCH] gpio: make GPIO_OMAP bool instead of tristate Sudip Mukherjee
2015-10-06 20:45 ` Grygorii Strashko
2015-10-07 7:27 ` Sudip Mukherjee
2015-10-07 19:19 ` Grygorii Strashko [this message]
2015-10-16 15:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56157024.1070905@ti.com \
--to=grygorii.strashko@ti.com \
--cc=arnd@arndb.de \
--cc=austin@peloton-tech.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).