From: Ray Jui <rjui@broadcom.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Jonas Gorski" <jogo@openwrt.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Pramod KUMAR" <pramodku@broadcom.com>,
"Kader Yılmaz" <kaderyilmaz.92@hotmail.com>,
"Vikram Prakash" <vikramp@broadcom.com>,
"Yendapally Reddy Dhananjaya Reddy" <yrdreddy@broadcom.com>
Subject: Re: [PATCH RFC/RFT 0/2] gpio: allow auto population of request/free
Date: Fri, 16 Oct 2015 14:10:40 -0700 [thread overview]
Message-ID: <562167D0.8030007@broadcom.com> (raw)
In-Reply-To: <CACRpkdbbqz6pFak1vaE8+-1_t5utQ+=fP3hwKvS=fJO8FJiZXw@mail.gmail.com>
On 10/16/2015 2:04 PM, Linus Walleij wrote:
> On Tue, Oct 13, 2015 at 10:31 PM, Ray Jui <rjui@broadcom.com> wrote:
>
>> One of the changes we made is to make use of the DT based gpio-ranges
>> properly, i.e., we are setting GPIO->pinmux mapping in device tree
>> instead of hardcoded in the driver. This feature is already supported by
>> of_gpiochip_add_pin_range, called by of_gpiochip_add, called by
>> gpiochip_add.
>>
>> Due to this, I'm not sure if the Cygnus GPIO driver is suitable as an
>> example for this change.
> (...)
>> Linus, please advise how we should proceed with this.
>
> It is more important that you switch to fetching the ranges from the
> device tree. That is a very important clean-up.
>
> Yours,
> Linus Walleij
>
Okay. Thanks for the clarification. Pramod (CCed on this email) will
likely be sending out various clean up patches early next week.
Thanks,
Ray
prev parent reply other threads:[~2015-10-16 21:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 15:48 [PATCH RFC/RFT 0/2] gpio: allow auto population of request/free Jonas Gorski
2015-10-11 15:48 ` [PATCH RFC/RFT 1/2] gpio: allow atomic registration of gpio chip with pin ranges Jonas Gorski
2015-10-13 20:32 ` Ray Jui
2015-10-16 21:10 ` Linus Walleij
2015-10-11 15:48 ` [PATCH RFC/RFT 2/2] pinctrl-cygnus-gpio: convert to use gpiochip_add_with_ranges Jonas Gorski
2015-10-13 20:34 ` Ray Jui
2015-10-13 20:31 ` [PATCH RFC/RFT 0/2] gpio: allow auto population of request/free Ray Jui
2015-10-16 21:04 ` Linus Walleij
2015-10-16 21:10 ` Ray Jui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562167D0.8030007@broadcom.com \
--to=rjui@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gnurou@gmail.com \
--cc=jogo@openwrt.org \
--cc=kaderyilmaz.92@hotmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=pramodku@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=vikramp@broadcom.com \
--cc=yrdreddy@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).