From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ray Jui Subject: Re: [PATCH RFC/RFT 0/2] gpio: allow auto population of request/free Date: Fri, 16 Oct 2015 14:10:40 -0700 Message-ID: <562167D0.8030007@broadcom.com> References: <1444578499-17980-1-git-send-email-jogo@openwrt.org> <561D6A10.1070801@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:35678 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbbJPVKm (ORCPT ); Fri, 16 Oct 2015 17:10:42 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Jonas Gorski , "linux-gpio@vger.kernel.org" , Alexandre Courbot , Florian Fainelli , Scott Branden , Pramod KUMAR , =?UTF-8?Q?Kader_Y=c4=b1lmaz?= , Vikram Prakash , Yendapally Reddy Dhananjaya Reddy On 10/16/2015 2:04 PM, Linus Walleij wrote: > On Tue, Oct 13, 2015 at 10:31 PM, Ray Jui wrote: > >> One of the changes we made is to make use of the DT based gpio-ranges >> properly, i.e., we are setting GPIO->pinmux mapping in device tree >> instead of hardcoded in the driver. This feature is already supported by >> of_gpiochip_add_pin_range, called by of_gpiochip_add, called by >> gpiochip_add. >> >> Due to this, I'm not sure if the Cygnus GPIO driver is suitable as an >> example for this change. > (...) >> Linus, please advise how we should proceed with this. > > It is more important that you switch to fetching the ranges from the > device tree. That is a very important clean-up. > > Yours, > Linus Walleij > Okay. Thanks for the clarification. Pramod (CCed on this email) will likely be sending out various clean up patches early next week. Thanks, Ray