From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Date: Wed, 28 Oct 2015 08:09:23 +0000 Message-ID: <563082B3.8040301@linaro.org> References: <1445102604-11502-1-git-send-email-mcoquelin.stm32@gmail.com> <1445102604-11502-9-git-send-email-mcoquelin.stm32@gmail.com> <562FEE85.3010204@suse.de> <562FF234.9010403@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <562FF234.9010403-l3A5Bk7waGM@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , Linus Walleij Cc: Maxime Coquelin , Mark Rutland , Rob Herring , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arnd Bergmann , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Bruno Herrera List-Id: linux-gpio@vger.kernel.org On 27/10/15 21:52, Andreas F=C3=A4rber wrote: > Am 27.10.2015 um 22:46 schrieb Linus Walleij: >> Heartbeat is awesome. > > Yes, it's awesome for testing, but not for a .dts file that ends up i= n a > distro (not the case here, of course) and keeps blinking on the desk. > > If someone wants LEDs to blink, they can set that via sysfs or by > modifying their .dts locally. > > sunxi chose to keep LEDs off my default. For qcom we had a similar > discussion some weeks ago. I don't regularly read Linux patches, so f= eel > free to skim the archives yourself. Among the existing DTS files there is pretty significant use of=20 heartbeat although its not absolute. There are 119 files that set a default-trigger, of these 91 (~75%)=20 include a line to configure a heartbeat. Personally I'd be very happy with heartbeat by default on STM32... I've= =20 seldom worked on a board without a default-enabled heartbeat so they=20 make me feel comfortable. ;-) Daniel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html