From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ray Jui Subject: Re: [PATCH] pinctrl: Delete unnecessary checks before the function call "pinctrl_unregister" Date: Thu, 5 Nov 2015 08:53:45 -0800 Message-ID: <563B8999.4010409@broadcom.com> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <563B810B.6050401@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:1222 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033200AbbKEQxs (ORCPT ); Thu, 5 Nov 2015 11:53:48 -0500 In-Reply-To: <563B810B.6050401@users.sourceforge.net> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: SF Markus Elfring , Jon Mason , Linus Walleij , Scott Branden , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Pramod Kumar On 11/5/2015 8:17 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 5 Nov 2015 17:10:22 +0100 > > The pinctrl_unregister() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c | 3 +-- > drivers/pinctrl/pinctrl-single.c | 5 +---- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c b/drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c > index 12a48f4..663ad0a 100644 > --- a/drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c > +++ b/drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c > @@ -638,8 +638,7 @@ static int cygnus_gpio_register_pinconf(struct cygnus_gpio *chip) > > static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip) > { > - if (chip->pctl) > - pinctrl_unregister(chip->pctl); > + pinctrl_unregister(chip->pctl); > } > > struct cygnus_gpio_data { > diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c > index ef04b96..d24e5f1 100644 > --- a/drivers/pinctrl/pinctrl-single.c > +++ b/drivers/pinctrl/pinctrl-single.c > @@ -1484,10 +1484,7 @@ static void pcs_irq_free(struct pcs_device *pcs) > static void pcs_free_resources(struct pcs_device *pcs) > { > pcs_irq_free(pcs); > - > - if (pcs->pctl) > - pinctrl_unregister(pcs->pctl); > - > + pinctrl_unregister(pcs->pctl); > pcs_free_funcs(pcs); > pcs_free_pingroups(pcs); > } > The change looks good to me, thanks! Reviewed-by: Ray Jui + Pramod since he's working on changes on the pinctrl-cygnus-gpio driver. Ray