[PATCH] pinctrl: bcm2835: Fix initial value for direction_output

[PATCH] pinctrl: bcm2835: Fix initial value for direction_output

[Stefan Wahren]

Currently the provided initial value for bcm2835_gpio_direction_output
has no effect. So fix this issue by changing the value before
changing the GPIO direction. As a result we need to move the function below
bcm2835_gpio_set.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
CC: Martin Sperl <kernel@martin.sperl.org>
CC: Stephen Warren <swarren@wwwdotorg.org>
---

This patch was inspired by this discussion [1].

[1] - http://lists.infradead.org/pipermail/linux-rpi-kernel/2015-April/001499.html

 drivers/pinctrl/bcm/pinctrl-bcm2835.c |   13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index 8efa235..fd1441b 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -352,12 +352,6 @@ static int bcm2835_gpio_get(struct gpio_chip *chip, unsigned offset)
 	return bcm2835_gpio_get_bit(pc, GPLEV0, offset);
 }
 
-static int bcm2835_gpio_direction_output(struct gpio_chip *chip,
-		unsigned offset, int value)
-{
-	return pinctrl_gpio_direction_output(chip->base + offset);
-}
-
 static void bcm2835_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
 {
 	struct bcm2835_pinctrl *pc = dev_get_drvdata(chip->dev);
@@ -365,6 +359,13 @@ static void bcm2835_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
 	bcm2835_gpio_set_bit(pc, value ? GPSET0 : GPCLR0, offset);
 }
 
+static int bcm2835_gpio_direction_output(struct gpio_chip *chip,
+		unsigned offset, int value)
+{
+	bcm2835_gpio_set(chip, offset, value);
+	return pinctrl_gpio_direction_output(chip->base + offset);
+}
+
 static int bcm2835_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
 {
 	struct bcm2835_pinctrl *pc = dev_get_drvdata(chip->dev);
-- 
1.7.9.5

Re: [PATCH] pinctrl: bcm2835: Fix initial value for direction_output

[Linus Walleij]

On Thu, Nov 19, 2015 at 1:32 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:

> Currently the provided initial value for bcm2835_gpio_direction_output
> has no effect. So fix this issue by changing the value before
> changing the GPIO direction. As a result we need to move the function below
> bcm2835_gpio_set.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> CC: Martin Sperl <kernel@martin.sperl.org>
> CC: Stephen Warren <swarren@wwwdotorg.org>

Waiting for Stephen's ACK on this.

Yours,
Linus Walleij

Re: [PATCH] pinctrl: bcm2835: Fix initial value for direction_output

[Eric Anholt]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Stefan Wahren <stefan.wahren@i2se.com> writes:

> Currently the provided initial value for bcm2835_gpio_direction_output
> has no effect. So fix this issue by changing the value before
> changing the GPIO direction. As a result we need to move the function below
> bcm2835_gpio_set.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> CC: Martin Sperl <kernel@martin.sperl.org>
> CC: Stephen Warren <swarren@wwwdotorg.org>

Acked-by: Eric Anholt <eric@anholt.net>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] pinctrl: bcm2835: Fix initial value for direction_output

[Stephen Warren]

On 11/18/2015 05:32 PM, Stefan Wahren wrote:
> Currently the provided initial value for bcm2835_gpio_direction_output
> has no effect. So fix this issue by changing the value before
> changing the GPIO direction. As a result we need to move the function below
> bcm2835_gpio_set.

Acked-by: Stephen Warren <swarren@wwwdotorg.org>

Re: [PATCH] pinctrl: bcm2835: Fix initial value for direction_output

[Stefan Wahren]

Am 02.12.2015 um 04:53 schrieb Stephen Warren:
> On 11/18/2015 05:32 PM, Stefan Wahren wrote:
>> Currently the provided initial value for bcm2835_gpio_direction_output
>> has no effect. So fix this issue by changing the value before
>> changing the GPIO direction. As a result we need to move the function below
>> bcm2835_gpio_set.
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
>

Should i resend the patch with

Suggested-by: Martin Sperl <kernel@martin.sperl.org>

?

Re: [PATCH] pinctrl: bcm2835: Fix initial value for direction_output

[Linus Walleij]

On Thu, Nov 19, 2015 at 1:32 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:

> Currently the provided initial value for bcm2835_gpio_direction_output
> has no effect. So fix this issue by changing the value before
> changing the GPIO direction. As a result we need to move the function below
> bcm2835_gpio_set.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> CC: Martin Sperl <kernel@martin.sperl.org>
> CC: Stephen Warren <swarren@wwwdotorg.org>

Patch applied for fixes.

Yours,
Linus Walleij

Re: [PATCH] pinctrl: bcm2835: Fix initial value for direction_output

[Linus Walleij]

On Wed, Dec 2, 2015 at 3:26 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Am 02.12.2015 um 04:53 schrieb Stephen Warren:
>> On 11/18/2015 05:32 PM, Stefan Wahren wrote:
>>> Currently the provided initial value for bcm2835_gpio_direction_output
>>> has no effect. So fix this issue by changing the value before
>>> changing the GPIO direction. As a result we need to move the function below
>>> bcm2835_gpio_set.
>> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
>>
>
> Should i resend the patch with
>
> Suggested-by: Martin Sperl <kernel@martin.sperl.org>

No, I added this when applying the patch.

Yours,
Linus Walleij