* Re: [PATCH 2/3] Add support for monitoring gpio switches
[not found] ` <20151204185713.GA22925@kroah.com>
@ 2015-12-05 10:42 ` Martyn Welch
0 siblings, 0 replies; only message in thread
From: Martyn Welch @ 2015-12-05 10:42 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arnd Bergmann, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, Kukjin Kim,
Krzysztof Kozlowski, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Olof Johansson, Linus Walleij,
Alexandre Courbot, linux-gpio
On 04/12/15 18:57, Greg Kroah-Hartman wrote:
> On Fri, Dec 04, 2015 at 05:31:14PM +0000, Martyn Welch wrote:
>> Select Chromebooks have gpio attached to switches used to cause the
>> firmware to enter alternative modes of operation and/or control other
>> device characteristics (such as write protection on flash devices). This
>> patch adds a driver that exposes a read-only interface to allow these
>> signals to be read from user space.
>>
>> This functionality has been generalised to provide support for any device
>> with device tree support which needs to identify a gpio as being used for a
>> specific task.
>>
>> Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>
>> ---
>> drivers/misc/Kconfig | 11 ++++
>> drivers/misc/Makefile | 1 +
>> drivers/misc/gpio-switch.c | 160 +++++++++++++++++++++++++++++++++++++++++++++
>
> Why isn't this in drivers/gpio/ ?
>
> why make it a misc driver?
>
I thought all the drivers in /drivers/gpio were gpio drivers, rather
than users of the gpio framework. Is that not the case?
Happy to move it if the consensus is that that's the correct place to
put it.
Martyn
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] only message in thread