linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ray Jui <rjui@broadcom.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Scott Branden <sbranden@broadcom.com>,
	Jon Mason <jonmason@broadcom.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH 2/3] pinctrl: nsp: add pinmux driver support for Broadcom NSP SoC
Date: Thu, 10 Dec 2015 14:58:34 -0800	[thread overview]
Message-ID: <566A039A.3030404@broadcom.com> (raw)
In-Reply-To: <CACRpkdaytru_AOK4p9Si9fJs6=DKgrqJ6HV4-To_a8Q+R+40jA@mail.gmail.com>

Hi Linus,

On 12/10/2015 8:50 AM, Linus Walleij wrote:
> On Mon, Nov 30, 2015 at 6:05 PM, Ray Jui <rjui@broadcom.com> wrote:
>> Hi Linus,
>>
>> On 11/30/2015 4:49 AM, Linus Walleij wrote:
>>>
>>> On Fri, Nov 20, 2015 at 6:57 PM, Yendapally Reddy Dhananjaya Reddy
>>> <yrdreddy@broadcom.com> wrote:
>>>
>>>> This adds the initial support of the Broadcom NSP pinmux driver.
>>>>
>>>> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com>
>>>
>>>
>>> So what does Ray and Stephen say about this?
>>>
>>> Is the hardware unique enough to warrant its own driver?
>>>
>>> Or should it utilize/extend one of the existing Broadcom
>>> drivers?
>>
>>
>> Currently, the IOMUX configurations in Cygnus, NSP, and NS2 are completely
>> different and require a separate driver to each of these SoCs. We now
>> realize the shortcomings and have been communicating with our ASIC team.
>> We'd like to fix this for the next-gen of our SoC. We are driving towards
>> using a register layout that will allow us to use just "pinctrl-single" and
>> "pinconf-single."
>
> OK can you provide your reviews for the NSP driver?
>
> Yours,
> Linus Walleij
>

Yes, I just replied to the email thread with my "Reviewed-by". In fact, 
both Scott and I reviewed the patches internally in Broadcom before they 
went out to public.

Thanks,

Ray

      reply	other threads:[~2015-12-10 22:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 17:57 [PATCH 2/3] pinctrl: nsp: add pinmux driver support for Broadcom NSP SoC Yendapally Reddy Dhananjaya Reddy
2015-11-30 12:49 ` Linus Walleij
2015-11-30 17:05   ` Ray Jui
2015-12-10 16:50     ` Linus Walleij
2015-12-10 22:58       ` Ray Jui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566A039A.3030404@broadcom.com \
    --to=rjui@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=jonmason@broadcom.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=swarren@wwwdotorg.org \
    --cc=yrdreddy@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).