From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH] gpio: pca953x: make inclusion of <linux/of_platform.h> unconditional
Date: Fri, 11 Dec 2015 09:05:36 +0000 [thread overview]
Message-ID: <566A91E0.7030902@codethink.co.uk> (raw)
In-Reply-To: <1449655574-6550-1-git-send-email-linus.walleij@linaro.org>
On 09/12/15 10:06, Linus Walleij wrote:
> After adding the DT matching in
> commit 6f29c9afbe636fc0e35c82a11eaf45c3b85eb07a
> "gpio: pca935x: fix of-only probed devices"
> compilation fails like this:
>
> CC [M] drivers/gpio/gpio-pca953x.o
> gpio-pca953x.c: In function ‘pca953x_probe’:
> gpio-pca953x.c:693:11: error: implicit declaration of
> function ‘of_match_device’ [-Werror=implicit-function-declaration]
> match = of_match_device(pca953x_dt_ids, &client->dev);
> ^
> gpio-pca953x.c:693:9: warning: assignment makes pointer from
> integer without a cast [-Wint-conversion]
> match = of_match_device(pca953x_dt_ids, &client->dev);
> ^
> cc1: some warnings being treated as errors
> ../scripts/Makefile.build:264: recipe for target
> 'drivers/gpio/gpio-pca953x.o' failed
>
> After removing the conditional inclusion guards compilation
> works fine again. Might be a module problem so that
> fix.
>
> Cc: Ben Dooks <ben.dooks@codethink.co.uk>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-pca953x.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 14729657a112..2eaf235a39e5 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -18,9 +18,7 @@
> #include <linux/i2c.h>
> #include <linux/platform_data/pca953x.h>
> #include <linux/slab.h>
> -#ifdef CONFIG_OF_GPIO
> #include <linux/of_platform.h>
> -#endif
> #include <linux/acpi.h>
I think you also need #include <linux/of_device.h>
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-12-11 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 10:06 [PATCH] gpio: pca953x: make inclusion of <linux/of_platform.h> unconditional Linus Walleij
2015-12-09 10:53 ` Ben Dooks
2015-12-10 18:30 ` Linus Walleij
2015-12-11 9:05 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566A91E0.7030902@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).