Re: [PATCH 134/182] m68k: gpio: switch to gpiochip_add_data()

[Greg Ungerer <gerg@uclinux.org>]

Hi Linus,

On 09/12/15 23:38, Linus Walleij wrote:
> We're planning to remove the gpiochip_add() function to swith
> to gpiochip_add_data() with NULL for data argument.
> 
> Cc: Greg Ungerer <gerg@uclinux.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Coldfire maintainers: please ACK this so I can take it through
> the GPIO tree.

Acked-by: Greg Ungerer <gerg@uclinux.org>

Thanks
Greg



> Also consider abstracting out GPIO and moving it to drivers/gpio
> at some point. It would involve some work though.
> ---
>  arch/m68k/coldfire/gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
> index e7e428681ec5..19c335d5031d 100644
> --- a/arch/m68k/coldfire/gpio.c
> +++ b/arch/m68k/coldfire/gpio.c
> @@ -178,7 +178,7 @@ static struct gpio_chip mcfgpio_chip = {
>  
>  static int __init mcfgpio_sysinit(void)
>  {
> -	gpiochip_add(&mcfgpio_chip);
> +	gpiochip_add_data(&mcfgpio_chip, NULL);
>  	return subsys_system_register(&mcfgpio_subsys, NULL);
>  }
>  
>