[PATCH 134/182] m68k: gpio: switch to gpiochip_add_data()

[PATCH 134/182] m68k: gpio: switch to gpiochip_add_data()

[Linus Walleij]

We're planning to remove the gpiochip_add() function to swith
to gpiochip_add_data() with NULL for data argument.

Cc: Greg Ungerer <gerg@uclinux.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Coldfire maintainers: please ACK this so I can take it through
the GPIO tree.
Also consider abstracting out GPIO and moving it to drivers/gpio
at some point. It would involve some work though.
---
 arch/m68k/coldfire/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
index e7e428681ec5..19c335d5031d 100644
--- a/arch/m68k/coldfire/gpio.c
+++ b/arch/m68k/coldfire/gpio.c
@@ -178,7 +178,7 @@ static struct gpio_chip mcfgpio_chip = {
 
 static int __init mcfgpio_sysinit(void)
 {
-	gpiochip_add(&mcfgpio_chip);
+	gpiochip_add_data(&mcfgpio_chip, NULL);
 	return subsys_system_register(&mcfgpio_subsys, NULL);
 }
 
-- 
2.4.3

Re: [PATCH 134/182] m68k: gpio: switch to gpiochip_add_data()

[Geert Uytterhoeven]

Hi Linus,

On Wed, Dec 9, 2015 at 2:38 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> We're planning to remove the gpiochip_add() function to swith
> to gpiochip_add_data() with NULL for data argument.

Just wondering, and I don't think this was clarified in the cover letter
(I'm not subscribed to linux-gpio, so I used a web archive): why don't you keep
gpiochip_add() as an inline wrapper around gpiochip_add_data()?
That would avoid conversions like this one.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 134/182] m68k: gpio: switch to gpiochip_add_data()

[Linus Walleij]

On Wed, Dec 9, 2015 at 2:59 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Linus,
>
> On Wed, Dec 9, 2015 at 2:38 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> We're planning to remove the gpiochip_add() function to swith
>> to gpiochip_add_data() with NULL for data argument.
>
> Just wondering, and I don't think this was clarified in the cover letter
> (I'm not subscribed to linux-gpio, so I used a web archive): why don't you keep
> gpiochip_add() as an inline wrapper around gpiochip_add_data()?
> That would avoid conversions like this one.

Because I don't want that kind of stuff around cluttering the place.
Besides it's only a handful drivers of the 180 or so I converted.

Yours,
Linus Walleij

Re: [PATCH 134/182] m68k: gpio: switch to gpiochip_add_data()

[Greg Ungerer]

Hi Linus,

On 09/12/15 23:38, Linus Walleij wrote:
> We're planning to remove the gpiochip_add() function to swith
> to gpiochip_add_data() with NULL for data argument.
> 
> Cc: Greg Ungerer <gerg@uclinux.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Coldfire maintainers: please ACK this so I can take it through
> the GPIO tree.

Acked-by: Greg Ungerer <gerg@uclinux.org>

Thanks
Greg



> Also consider abstracting out GPIO and moving it to drivers/gpio
> at some point. It would involve some work though.
> ---
>  arch/m68k/coldfire/gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
> index e7e428681ec5..19c335d5031d 100644
> --- a/arch/m68k/coldfire/gpio.c
> +++ b/arch/m68k/coldfire/gpio.c
> @@ -178,7 +178,7 @@ static struct gpio_chip mcfgpio_chip = {
>  
>  static int __init mcfgpio_sysinit(void)
>  {
> -	gpiochip_add(&mcfgpio_chip);
> +	gpiochip_add_data(&mcfgpio_chip, NULL);
>  	return subsys_system_register(&mcfgpio_subsys, NULL);
>  }
>  
>