* [PATCH 37/54] mips: ar7/gpio: Be sure to clamp return value
@ 2015-12-22 14:40 Linus Walleij
2015-12-22 22:05 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2015-12-22 14:40 UTC (permalink / raw)
To: linux-gpio, linux-mips, Ralf Baechle; +Cc: Linus Walleij, Alban Bedel
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: linux-mips@linux-mips.org
Cc: Alban Bedel <albeu@free.fr>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/mips/ar7/gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/ar7/gpio.c b/arch/mips/ar7/gpio.c
index f4930456eb8e..f969f583c68c 100644
--- a/arch/mips/ar7/gpio.c
+++ b/arch/mips/ar7/gpio.c
@@ -37,7 +37,7 @@ static int ar7_gpio_get_value(struct gpio_chip *chip, unsigned gpio)
container_of(chip, struct ar7_gpio_chip, chip);
void __iomem *gpio_in = gpch->regs + AR7_GPIO_INPUT;
- return readl(gpio_in) & (1 << gpio);
+ return !!(readl(gpio_in) & (1 << gpio));
}
static int titan_gpio_get_value(struct gpio_chip *chip, unsigned gpio)
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 37/54] mips: ar7/gpio: Be sure to clamp return value
2015-12-22 14:40 [PATCH 37/54] mips: ar7/gpio: Be sure to clamp return value Linus Walleij
@ 2015-12-22 22:05 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2015-12-22 22:05 UTC (permalink / raw)
To: Linus Walleij, linux-gpio, linux-mips, Ralf Baechle; +Cc: Alban Bedel
On 22/12/15 06:40, Linus Walleij wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: linux-mips@linux-mips.org
> Cc: Alban Bedel <albeu@free.fr>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-22 22:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-22 14:40 [PATCH 37/54] mips: ar7/gpio: Be sure to clamp return value Linus Walleij
2015-12-22 22:05 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).