From: Laxman Dewangan <ldewangan@nvidia.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org,
broonie@kernel.org, a.zummo@towertech.it,
alexandre.belloni@free-electrons.com, lgirdwood@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com,
swarren@nvidia.com, treding@nvidia.com, k.kozlowski@samsung.com
Subject: Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings
Date: Tue, 12 Jan 2016 16:50:58 +0530 [thread overview]
Message-ID: <5694E19A.2050107@nvidia.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1601121226060.5214@hadrien>
Hi Julia,
Thanks for pointing this issue.
What script do you run to get this error?
I tried to run script/coccicheck and it did not showed this issue.
When I run make with coccicheck per Documentation, it did not show
specific to this error. Although, there was lots of output.
I want to get this type of error by running script.
Any command for this?
Thanks,
Laxman
On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote:
> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>
> Generated by: scripts/coccinelle/misc/of_table.cocci
>
> CC: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
> rtc-max77xxx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/rtc/rtc-max77xxx.c
> +++ b/drivers/rtc/rtc-max77xxx.c
> @@ -480,6 +480,7 @@ static const struct platform_device_id m
> { .name = "max77xxx-rtc", },
> { .name = "max77620-rtc", },
> { .name = "max20024-rtc", },
> + {},
> };
>
> static struct platform_driver max77xxx_rtc_driver = {
prev parent reply other threads:[~2016-01-12 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 11:27 [PATCH] rtc: max77xxx: fix of_table.cocci warnings Julia Lawall
2016-01-12 11:20 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5694E19A.2050107@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=julia.lawall@lip6.fr \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).