From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH V4 1/5] DT: mfd: add device-tree binding doc fro PMIC
 max77620/max20024
Date: Tue, 26 Jan 2016 21:54:20 +0530
Message-ID: <56A79DB4.6090000@nvidia.com>
References: <1453198783-28383-1-git-send-email-ldewangan@nvidia.com> <1453198783-28383-2-git-send-email-ldewangan@nvidia.com> <20160125115610.GC3368@x1> <56A63A85.6060609@nvidia.com> <20160126145854.GC3368@x1>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-gpio-owner@vger.kernel.org>
Received: from hqemgate16.nvidia.com ([216.228.121.65]:6734 "EHLO
	hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S966659AbcAZQfT (ORCPT
	<rfc822;linux-gpio@vger.kernel.org>); Tue, 26 Jan 2016 11:35:19 -0500
In-Reply-To: <20160126145854.GC3368@x1>
Sender: linux-gpio-owner@vger.kernel.org
List-Id: linux-gpio@vger.kernel.org
To: Lee Jones <lee.jones@linaro.org>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, k.kozlowski@samsung.com, vreddytalla@nvidia.com


On Tuesday 26 January 2016 08:28 PM, Lee Jones wrote:
> On Mon, 25 Jan 2016, Laxman Dewangan wrote:
>
>> Hmm. I describe the boolean and tristate only. Do I need to define
>> type for integer,string also?
> I wouldn't describe any of them.  It's normally pretty obvious which
> properties are boolean by the lack of required cell description.
>

Rob suggested to use the type also for Boolean and tristate. I think it 
is good to have for all places that what type of values are valid.


>>>> +The property for fps child nodes as:
>>>> +Required properties:
>>>> +	-reg: FPS number like 0, 1, 2 for FPS0, FPS1 and FPS2 respectively.
>>> I'm surprised Rob Acked this.  We don't usually do device numbers in DT.
>> What is best way to make the child node for FPS and differentiate FPS0,1, 2?
>> What is your suggestion here?
> There are lots of ways you can solve this and so many examples of
> others doing so.  I suggest you have a look at some DTS files and
> figure it out.  One possible solution is to use different compatible
> strings.
Here, I think I can go similar to regulators where child node name 
identifies the regulators.

     fps-config {
         fps0 {
             maxim,fps-time-period-us = <1280>;
             maxim,fps-enable-input = <FPS_EN_SRC_EN0>;
         };

         fps1 {
             maxim,fps-time-period-us = <2560>;
             maxim,fps-enable-input = <FPS_EN_SRC_EN1>;
         };

         fps2 {
             maxim,fps-time-period-us = <640>;
             maxim,fps-enable-input = <FPS_EN_SRC_SW>;
         };
     };

So node name gives the FPS name.

>>> +Pinmux and GPIO:
>>> +===============
>>> I think this whole section needs moving to ../pinctrl and needs to be
>>> reviewed by Linus W.
>> Is this mean I need to create DT binding doc for the each subsystem
>> differently?
>> Actually during AS3722, I had different understanding to have single file.
> Yes, that way you have each of the the subsystem experts review your
> documentation.  You can then link to them from this document.
OK, I will add different dt binding doc in respective driver and squash 
that with respected submodule drivers.