* [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type
[not found] <4cc3a3a7a74c7a1894892a85aa7eabbd1534fe96.1451484758.git.geliangtang@163.com>
@ 2015-12-30 14:16 ` Geliang Tang
2016-01-27 13:56 ` Linus Walleij
2016-01-28 14:29 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Geliang Tang @ 2015-12-30 14:16 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot; +Cc: Geliang Tang, linux-gpio, linux-kernel
Use irq_data_get_chip_type() instead of container_of().
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
drivers/gpio/gpio-davinci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 65ebaef..aaa1a249 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -435,8 +435,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
{
static struct irq_chip_type gpio_unbanked;
- gpio_unbanked = *container_of(irq_get_chip(irq),
- struct irq_chip_type, chip);
+ gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
return &gpio_unbanked.chip;
};
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type
2015-12-30 14:16 ` [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type Geliang Tang
@ 2016-01-27 13:56 ` Linus Walleij
2016-01-27 16:35 ` Grygorii Strashko
2016-01-28 14:29 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2016-01-27 13:56 UTC (permalink / raw)
To: Geliang Tang, Grygorii Strashko, Santosh Shilimkar
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang <geliangtang@163.com> wrote:
> Use irq_data_get_chip_type() instead of container_of().
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> drivers/gpio/gpio-davinci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 65ebaef..aaa1a249 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -435,8 +435,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
> {
> static struct irq_chip_type gpio_unbanked;
>
> - gpio_unbanked = *container_of(irq_get_chip(irq),
> - struct irq_chip_type, chip);
> + gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
>
> return &gpio_unbanked.chip;
> };
Grygorii/Santosh, can you ACK/comment on this patch?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type
2016-01-27 13:56 ` Linus Walleij
@ 2016-01-27 16:35 ` Grygorii Strashko
2016-01-27 19:03 ` santosh shilimkar
0 siblings, 1 reply; 5+ messages in thread
From: Grygorii Strashko @ 2016-01-27 16:35 UTC (permalink / raw)
To: Linus Walleij, Geliang Tang, Santosh Shilimkar, Sekhar Nori
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On 01/27/2016 03:56 PM, Linus Walleij wrote:
> On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang <geliangtang@163.com> wrote:
>
>> Use irq_data_get_chip_type() instead of container_of().
>>
>> Signed-off-by: Geliang Tang <geliangtang@163.com>
>> ---
>> drivers/gpio/gpio-davinci.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index 65ebaef..aaa1a249 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -435,8 +435,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
>> {
>> static struct irq_chip_type gpio_unbanked;
>>
>> - gpio_unbanked = *container_of(irq_get_chip(irq),
>> - struct irq_chip_type, chip);
>> + gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
>>
>> return &gpio_unbanked.chip;
>> };
>
> Grygorii/Santosh, can you ACK/comment on this patch?
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type
2016-01-27 16:35 ` Grygorii Strashko
@ 2016-01-27 19:03 ` santosh shilimkar
0 siblings, 0 replies; 5+ messages in thread
From: santosh shilimkar @ 2016-01-27 19:03 UTC (permalink / raw)
To: Grygorii Strashko, Linus Walleij, Geliang Tang, Santosh Shilimkar,
Sekhar Nori
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On 1/27/2016 8:35 AM, Grygorii Strashko wrote:
> On 01/27/2016 03:56 PM, Linus Walleij wrote:
>> On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang <geliangtang@163.com>
>> wrote:
>>
>>> Use irq_data_get_chip_type() instead of container_of().
>>>
>>> Signed-off-by: Geliang Tang <geliangtang@163.com>
>>> ---
>>> drivers/gpio/gpio-davinci.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>>> index 65ebaef..aaa1a249 100644
>>> --- a/drivers/gpio/gpio-davinci.c
>>> +++ b/drivers/gpio/gpio-davinci.c
>>> @@ -435,8 +435,7 @@ static struct irq_chip
>>> *davinci_gpio_get_irq_chip(unsigned int irq)
>>> {
>>> static struct irq_chip_type gpio_unbanked;
>>>
>>> - gpio_unbanked = *container_of(irq_get_chip(irq),
>>> - struct irq_chip_type, chip);
>>> + gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
>>>
>>> return &gpio_unbanked.chip;
>>> };
>>
>> Grygorii/Santosh, can you ACK/comment on this patch?
>>
>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type
2015-12-30 14:16 ` [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type Geliang Tang
2016-01-27 13:56 ` Linus Walleij
@ 2016-01-28 14:29 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2016-01-28 14:29 UTC (permalink / raw)
To: Geliang Tang
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang <geliangtang@163.com> wrote:
> Use irq_data_get_chip_type() instead of container_of().
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
Patch applied with Grygorii's and Santosh's tags.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-28 14:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4cc3a3a7a74c7a1894892a85aa7eabbd1534fe96.1451484758.git.geliangtang@163.com>
2015-12-30 14:16 ` [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type Geliang Tang
2016-01-27 13:56 ` Linus Walleij
2016-01-27 16:35 ` Grygorii Strashko
2016-01-27 19:03 ` santosh shilimkar
2016-01-28 14:29 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).