From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Breathitt Gray Subject: Re: [PATCH 0/7] Use devm_request_region Date: Tue, 2 Feb 2016 19:46:34 -0500 Message-ID: <56B14DEA.2060104@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Courbot Cc: Linus Walleij , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List List-Id: linux-gpio@vger.kernel.org On 02/02/2016 07:26 PM, Alexandre Courbot wrote: > On Tue, Feb 2, 2016 at 8:54 AM, William Breathitt Gray > wrote: >> By the time request_region is called in several GPIO drivers, a >> corresponding device structure has already been allocated. The >> devm_request_region function should be used to help simplify the cleanup >> code and reduce the possible points of failure. >> >> William Breathitt Gray (7): >> gpio: 104-dio-48e: Use devm_request_region >> gpio: 104-idi-48: Use devm_request_region >> gpio: 104-idio-16: Use devm_request_region >> gpio: amd8111: Use devm_request_region >> gpio: ich: Use devm_request_region >> gpio: sch311x: Use devm_request_region >> gpio: ws16c48: Use devm_request_region >> >> drivers/gpio/gpio-104-dio-48e.c | 22 +++++++----------- >> drivers/gpio/gpio-104-idi-48.c | 22 +++++++----------- >> drivers/gpio/gpio-104-idio-16.c | 22 +++++++----------- >> drivers/gpio/gpio-amd8111.c | 7 +++--- >> drivers/gpio/gpio-ich.c | 51 ++++++++--------------------------------- >> drivers/gpio/gpio-sch311x.c | 7 +++--- >> drivers/gpio/gpio-ws16c48.c | 22 +++++++----------- >> 7 files changed, 47 insertions(+), 106 deletions(-) > > Did a quick review and this looks all good, modulo the compile warning > on patch 6. > > Reviewed-by: Alexandre Courbot The compile warning for patch 6 appears to be benign and preexisting: an unused variable. Since the warning is unrelated to this patchset, I'll submit a separate patch to remove the unused variable so that this warning will no longer show up on later compiles. William Breathitt Gray