* [PATCH 0/2] gpio: davinci: driver fixes
@ 2016-01-28 13:38 Keerthy
2016-01-28 13:38 ` [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Keerthy
2016-01-28 13:38 ` [PATCH 2/2] gpio: davinci: Fix the number of controllers allocated Keerthy
0 siblings, 2 replies; 9+ messages in thread
From: Keerthy @ 2016-01-28 13:38 UTC (permalink / raw)
To: linus.walleij, gnurou
Cc: linux-gpio, linux-kernel, grygorii.strashko, lokeshvutla,
j-keerthy
The series has couple of for the gpio driver.
Keerthy (1):
gpio: davinci: Add the missing of-node pointer in the
irq_domain_add_legacy function call
Lokesh Vutla (1):
gpio: davinci: Fix the number of controllers allocated
drivers/gpio/gpio-davinci.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call 2016-01-28 13:38 [PATCH 0/2] gpio: davinci: driver fixes Keerthy @ 2016-01-28 13:38 ` Keerthy 2016-01-28 14:18 ` Grygorii Strashko 2016-02-10 10:00 ` Linus Walleij 2016-01-28 13:38 ` [PATCH 2/2] gpio: davinci: Fix the number of controllers allocated Keerthy 1 sibling, 2 replies; 9+ messages in thread From: Keerthy @ 2016-01-28 13:38 UTC (permalink / raw) To: linus.walleij, gnurou Cc: linux-gpio, linux-kernel, grygorii.strashko, lokeshvutla, j-keerthy Currently the first parameter of irq_domain_add_legacy is NULL. irq_find_host function returns NULL when we do not populate the of_node and hence irq_of_parse_and_map call fails whenever we want to request a gpio irq. This fixes the request_irq failures for gpio interrupts. Signed-off-by: Keerthy <j-keerthy@ti.com> --- drivers/gpio/gpio-davinci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index ec58f42..c889f31 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) return irq; } - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0, + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0, &davinci_gpio_irq_ops, chips); if (!irq_domain) { -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call 2016-01-28 13:38 ` [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Keerthy @ 2016-01-28 14:18 ` Grygorii Strashko 2016-02-08 9:48 ` Keerthy 2016-02-10 10:00 ` Linus Walleij 1 sibling, 1 reply; 9+ messages in thread From: Grygorii Strashko @ 2016-01-28 14:18 UTC (permalink / raw) To: Keerthy, linus.walleij, Alexandre Courbot Cc: linux-gpio, linux-kernel, lokeshvutla, Santosh Shilimkar, Sekhar Nori On 01/28/2016 03:38 PM, Keerthy wrote: > Currently the first parameter of irq_domain_add_legacy is NULL. > irq_find_host function returns NULL when we do not populate the of_node > and hence irq_of_parse_and_map call fails whenever we want to request a > gpio irq. This fixes the request_irq failures for gpio interrupts. > > Signed-off-by: Keerthy <j-keerthy@ti.com> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > drivers/gpio/gpio-davinci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c > index ec58f42..c889f31 100644 > --- a/drivers/gpio/gpio-davinci.c > +++ b/drivers/gpio/gpio-davinci.c > @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) > return irq; > } > > - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0, > + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0, > &davinci_gpio_irq_ops, > chips); > if (!irq_domain) { > -- regards, -grygorii ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call 2016-01-28 14:18 ` Grygorii Strashko @ 2016-02-08 9:48 ` Keerthy 0 siblings, 0 replies; 9+ messages in thread From: Keerthy @ 2016-02-08 9:48 UTC (permalink / raw) To: Grygorii Strashko, Keerthy, linus.walleij, Alexandre Courbot Cc: linux-gpio, linux-kernel, lokeshvutla, Santosh Shilimkar, Sekhar Nori On Thursday 28 January 2016 07:48 PM, Grygorii Strashko wrote: > On 01/28/2016 03:38 PM, Keerthy wrote: >> Currently the first parameter of irq_domain_add_legacy is NULL. >> irq_find_host function returns NULL when we do not populate the of_node >> and hence irq_of_parse_and_map call fails whenever we want to request a >> gpio irq. This fixes the request_irq failures for gpio interrupts. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> > > Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> A gentle ping on this patch. Thanks Grygorii for the review. > >> --- >> drivers/gpio/gpio-davinci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c >> index ec58f42..c889f31 100644 >> --- a/drivers/gpio/gpio-davinci.c >> +++ b/drivers/gpio/gpio-davinci.c >> @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct >> platform_device *pdev) >> return irq; >> } >> >> - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0, >> + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0, >> &davinci_gpio_irq_ops, >> chips); >> if (!irq_domain) { >> > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call 2016-01-28 13:38 ` [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Keerthy 2016-01-28 14:18 ` Grygorii Strashko @ 2016-02-10 10:00 ` Linus Walleij 1 sibling, 0 replies; 9+ messages in thread From: Linus Walleij @ 2016-02-10 10:00 UTC (permalink / raw) To: Keerthy Cc: Alexandre Courbot, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Grygorii Strashko, Lokesh Vutla On Thu, Jan 28, 2016 at 2:38 PM, Keerthy <j-keerthy@ti.com> wrote: > Currently the first parameter of irq_domain_add_legacy is NULL. > irq_find_host function returns NULL when we do not populate the of_node > and hence irq_of_parse_and_map call fails whenever we want to request a > gpio irq. This fixes the request_irq failures for gpio interrupts. > > Signed-off-by: Keerthy <j-keerthy@ti.com> Patch applied for fixes with Grygorii's review tag. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] gpio: davinci: Fix the number of controllers allocated 2016-01-28 13:38 [PATCH 0/2] gpio: davinci: driver fixes Keerthy 2016-01-28 13:38 ` [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Keerthy @ 2016-01-28 13:38 ` Keerthy 2016-01-28 14:18 ` Grygorii Strashko 2016-02-10 10:01 ` Linus Walleij 1 sibling, 2 replies; 9+ messages in thread From: Keerthy @ 2016-01-28 13:38 UTC (permalink / raw) To: linus.walleij, gnurou Cc: linux-gpio, linux-kernel, grygorii.strashko, lokeshvutla, j-keerthy From: Lokesh Vutla <lokeshvutla@ti.com> Driver only needs to allocate for [ngpio / 32] controllers, as each controller handles 32 gpios. But the current driver allocates for ngpio of which the extra allocated are unused. Fix it be registering only the required number of controllers. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> Signed-off-by: Keerthy <j-keerthy@ti.com> --- drivers/gpio/gpio-davinci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index c889f31..cd007a6 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -195,7 +195,7 @@ static int davinci_gpio_of_xlate(struct gpio_chip *gc, static int davinci_gpio_probe(struct platform_device *pdev) { int i, base; - unsigned ngpio; + unsigned ngpio, nbank; struct davinci_gpio_controller *chips; struct davinci_gpio_platform_data *pdata; struct davinci_gpio_regs __iomem *regs; @@ -224,8 +224,9 @@ static int davinci_gpio_probe(struct platform_device *pdev) if (WARN_ON(ARCH_NR_GPIOS < ngpio)) ngpio = ARCH_NR_GPIOS; + nbank = DIV_ROUND_UP(ngpio, 32); chips = devm_kzalloc(dev, - ngpio * sizeof(struct davinci_gpio_controller), + nbank * sizeof(struct davinci_gpio_controller), GFP_KERNEL); if (!chips) return -ENOMEM; -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] gpio: davinci: Fix the number of controllers allocated 2016-01-28 13:38 ` [PATCH 2/2] gpio: davinci: Fix the number of controllers allocated Keerthy @ 2016-01-28 14:18 ` Grygorii Strashko 2016-02-08 9:47 ` Keerthy 2016-02-10 10:01 ` Linus Walleij 1 sibling, 1 reply; 9+ messages in thread From: Grygorii Strashko @ 2016-01-28 14:18 UTC (permalink / raw) To: Keerthy, linus.walleij, gnurou Cc: linux-gpio, linux-kernel, lokeshvutla, Santosh Shilimkar, Sekhar Nori On 01/28/2016 03:38 PM, Keerthy wrote: > From: Lokesh Vutla <lokeshvutla@ti.com> > > Driver only needs to allocate for [ngpio / 32] controllers, > as each controller handles 32 gpios. But the current driver > allocates for ngpio of which the extra allocated are unused. > Fix it be registering only the required number of controllers. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > Signed-off-by: Keerthy <j-keerthy@ti.com> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > drivers/gpio/gpio-davinci.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c > index c889f31..cd007a6 100644 > --- a/drivers/gpio/gpio-davinci.c > +++ b/drivers/gpio/gpio-davinci.c > @@ -195,7 +195,7 @@ static int davinci_gpio_of_xlate(struct gpio_chip *gc, > static int davinci_gpio_probe(struct platform_device *pdev) > { > int i, base; > - unsigned ngpio; > + unsigned ngpio, nbank; > struct davinci_gpio_controller *chips; > struct davinci_gpio_platform_data *pdata; > struct davinci_gpio_regs __iomem *regs; > @@ -224,8 +224,9 @@ static int davinci_gpio_probe(struct platform_device *pdev) > if (WARN_ON(ARCH_NR_GPIOS < ngpio)) > ngpio = ARCH_NR_GPIOS; > > + nbank = DIV_ROUND_UP(ngpio, 32); > chips = devm_kzalloc(dev, > - ngpio * sizeof(struct davinci_gpio_controller), > + nbank * sizeof(struct davinci_gpio_controller), > GFP_KERNEL); > if (!chips) > return -ENOMEM; > -- regards, -grygorii ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] gpio: davinci: Fix the number of controllers allocated 2016-01-28 14:18 ` Grygorii Strashko @ 2016-02-08 9:47 ` Keerthy 0 siblings, 0 replies; 9+ messages in thread From: Keerthy @ 2016-02-08 9:47 UTC (permalink / raw) To: Grygorii Strashko, Keerthy, linus.walleij, gnurou Cc: linux-gpio, linux-kernel, lokeshvutla, Santosh Shilimkar, Sekhar Nori On Thursday 28 January 2016 07:48 PM, Grygorii Strashko wrote: > On 01/28/2016 03:38 PM, Keerthy wrote: >> From: Lokesh Vutla <lokeshvutla@ti.com> >> >> Driver only needs to allocate for [ngpio / 32] controllers, >> as each controller handles 32 gpios. But the current driver >> allocates for ngpio of which the extra allocated are unused. >> Fix it be registering only the required number of controllers. >> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >> Signed-off-by: Keerthy <j-keerthy@ti.com> > > Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> A gentle ping on this patch. Thanks Grygorii for the review. > >> --- >> drivers/gpio/gpio-davinci.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c >> index c889f31..cd007a6 100644 >> --- a/drivers/gpio/gpio-davinci.c >> +++ b/drivers/gpio/gpio-davinci.c >> @@ -195,7 +195,7 @@ static int davinci_gpio_of_xlate(struct gpio_chip >> *gc, >> static int davinci_gpio_probe(struct platform_device *pdev) >> { >> int i, base; >> - unsigned ngpio; >> + unsigned ngpio, nbank; >> struct davinci_gpio_controller *chips; >> struct davinci_gpio_platform_data *pdata; >> struct davinci_gpio_regs __iomem *regs; >> @@ -224,8 +224,9 @@ static int davinci_gpio_probe(struct >> platform_device *pdev) >> if (WARN_ON(ARCH_NR_GPIOS < ngpio)) >> ngpio = ARCH_NR_GPIOS; >> >> + nbank = DIV_ROUND_UP(ngpio, 32); >> chips = devm_kzalloc(dev, >> - ngpio * sizeof(struct davinci_gpio_controller), >> + nbank * sizeof(struct davinci_gpio_controller), >> GFP_KERNEL); >> if (!chips) >> return -ENOMEM; >> > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] gpio: davinci: Fix the number of controllers allocated 2016-01-28 13:38 ` [PATCH 2/2] gpio: davinci: Fix the number of controllers allocated Keerthy 2016-01-28 14:18 ` Grygorii Strashko @ 2016-02-10 10:01 ` Linus Walleij 1 sibling, 0 replies; 9+ messages in thread From: Linus Walleij @ 2016-02-10 10:01 UTC (permalink / raw) To: Keerthy Cc: Alexandre Courbot, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Grygorii Strashko, Lokesh Vutla On Thu, Jan 28, 2016 at 2:38 PM, Keerthy <j-keerthy@ti.com> wrote: > From: Lokesh Vutla <lokeshvutla@ti.com> > > Driver only needs to allocate for [ngpio / 32] controllers, > as each controller handles 32 gpios. But the current driver > allocates for ngpio of which the extra allocated are unused. > Fix it be registering only the required number of controllers. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > Signed-off-by: Keerthy <j-keerthy@ti.com> Patch applied for fixes with Grygorii's review tag. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-02-10 10:01 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-01-28 13:38 [PATCH 0/2] gpio: davinci: driver fixes Keerthy 2016-01-28 13:38 ` [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Keerthy 2016-01-28 14:18 ` Grygorii Strashko 2016-02-08 9:48 ` Keerthy 2016-02-10 10:00 ` Linus Walleij 2016-01-28 13:38 ` [PATCH 2/2] gpio: davinci: Fix the number of controllers allocated Keerthy 2016-01-28 14:18 ` Grygorii Strashko 2016-02-08 9:47 ` Keerthy 2016-02-10 10:01 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).