From: Lars-Peter Clausen <lars@metafoo.de>
To: Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Russell King <rmk+kernel@arm.linux.org.uk>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@imgtec.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 1/4] gpio: remove broken irq_to_gpio() interface
Date: Mon, 15 Feb 2016 17:01:09 +0100 [thread overview]
Message-ID: <56C1F645.1070405@metafoo.de> (raw)
In-Reply-To: <1455551208-2825510-2-git-send-email-arnd@arndb.de>
On 02/15/2016 04:46 PM, Arnd Bergmann wrote:
> +static inline __deprecated int irq_to_gpio(unsigned int irq)
> +{
> + /* this has clearly not worked for a long time */
> + return -EINVAL;
> +}
> +
> #define IRQ_TO_BIT(irq) BIT(irq_to_gpio(irq) & 0x1f)
The issue seems to be a fallout from commit 832f5dacfa0b ("MIPS: Remove all
the uses of custom gpio.h").
The irq_to_gpio() should be replaced with "(irq - JZ4740_IRQ_GPIO(0))".
- Lars
next prev parent reply other threads:[~2016-02-15 16:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 19:53 [PATCH 0/2] GPIO: Clean up asm/gpio.h Bjorn Helgaas
2016-02-02 19:53 ` [PATCH 1/2] gpio: Include linux/gpio.h instead of asm/gpio.h Bjorn Helgaas
2016-02-03 0:02 ` Alexandre Courbot
2016-02-15 13:35 ` Linus Walleij
2016-02-02 19:53 ` [PATCH 2/2] gpio: Remove unused asm/gpio.h files Bjorn Helgaas
2016-02-03 0:03 ` Alexandre Courbot
2016-02-03 8:19 ` [PATCH 0/2] GPIO: Clean up asm/gpio.h Thomas Gleixner
2016-02-05 13:43 ` Linus Walleij
2016-02-15 15:46 ` [PATCH 0/4] clean up irq_to_gpio and asm/gpio.h Arnd Bergmann
2016-02-15 15:46 ` [PATCH 1/4] gpio: remove broken irq_to_gpio() interface Arnd Bergmann
2016-02-15 16:01 ` Lars-Peter Clausen [this message]
2016-02-15 20:16 ` Arnd Bergmann
2016-02-16 15:42 ` Linus Walleij
2016-02-16 15:45 ` Arnd Bergmann
2016-02-16 15:53 ` Linus Walleij
2016-02-15 15:46 ` [PATCH 2/4] gpio: ks8695: remove irq_to_gpio function Arnd Bergmann
2016-02-16 15:43 ` Linus Walleij
2016-02-15 15:46 ` [PATCH 3/4] gpio: ep93xx: remove private " Arnd Bergmann
2016-02-16 15:51 ` Linus Walleij
2016-02-16 16:12 ` Arnd Bergmann
2016-02-15 15:46 ` [PATCH 4/4] ARM: remove asm/gpio.h Arnd Bergmann
2016-02-15 16:03 ` Russell King - ARM Linux
2016-02-16 15:37 ` [PATCH v2 0/5] gpio: clean up irq_to_gpio and ARCH_NR_GPIOS Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C1F645.1070405@metafoo.de \
--to=lars@metafoo.de \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).