From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH 10/61] gpio: ath79: Use devm_gpiochip_add_data() for gpio registration Date: Tue, 23 Feb 2016 20:28:24 +0530 Message-ID: <56CC7390.6050805@nvidia.com> References: <1456150130-2668-1-git-send-email-ldewangan@nvidia.com> <1456150130-2668-11-git-send-email-ldewangan@nvidia.com> <20160222211323.5c10533f@tock> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160222211323.5c10533f@tock> Sender: linux-kernel-owner@vger.kernel.org To: Alban Cc: linus.walleij@linaro.org, gnurou@gmail.com, michael.hennerich@analog.com, corbet@lwn.net, rjui@broadcom.com, shc_work@mail.ru, support.opensource@diasemi.com, swarren@wwwdotorg.org, thierry.reding@gmail.com, bjorn.andersson@sonymobile.com, a.kesavan@samsung.com, gregkh@linuxfoundation.org, catalin.marinas@arm.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.wolfsonmicro.com, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org List-Id: linux-gpio@vger.kernel.org On Tuesday 23 February 2016 01:43 AM, Alban wrote: > On Mon, 22 Feb 2016 19:37:59 +0530 > Laxman Dewangan wrote: > >> Use devm_gpiochip_add_data() for GPIO registration. >> >> Signed-off-by: Laxman Dewangan >> Cc: Alban Bedel >> --- >> drivers/gpio/gpio-ath79.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c >> index d13dd13..a6aad59 100644 >> --- a/drivers/gpio/gpio-ath79.c >> +++ b/drivers/gpio/gpio-ath79.c >> @@ -182,7 +182,7 @@ static int ath79_gpio_probe(struct platform_device *pdev) >> ctrl->chip.direction_output = ar934x_gpio_direction_output; >> } >> >> - err = gpiochip_add_data(&ctrl->chip, ctrl); >> + err = devm_gpiochip_add_data(&pdev->dev, &ctrl->chip, ctrl); >> if (err) { >> dev_err(&pdev->dev, >> "cannot add AR71xx GPIO chip, error=%d", err); > With the patches already applied to the devel branch a few more changes > will be needed to remove the calls to gpiochip_remove() in the probe > error path and the remove callback. > OK, I will drop this patch when provide the git pointer to Linus. We can work on this later.