From: Marek Vasut <marex@denx.de>
To: Tien Hock Loh <thloh@altera.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
"thloh85@gmail.com" <thloh85@gmail.com>
Subject: Re: gpio-altera OF binding discrepancy
Date: Mon, 29 Feb 2016 17:22:03 +0100 [thread overview]
Message-ID: <56D4702B.1090205@denx.de> (raw)
In-Reply-To: <1456758924.1035.4.camel@ubuntu>
On 02/29/2016 04:15 PM, Tien Hock Loh wrote:
> Hi Marex
Hi Tien!
> Yeah, it must've been a typo when I wrote the document, good catch
> there. Can you help submit a patch to this?
Sure, I will do shortly (today or tomorrow).
> Thanks
>
> On Sat, 2016-02-27 at 03:10 +0100, marex@denx.de wrote:
>> Hi!
>>
>> I've just checked linux-4.4 and linux-next and discovered the following
>> issue.
>>
>> The Documentation/devicetree/bindings/gpio/gpio-altera.txt lists OF
>> property altr,interrupt-trigger , which is not used anywhere in the
>> kernel tree.
>>
>> The drivers/gpio/gpio-altera.c on the other hand checks for a mandatory
>> OF property altr,interrupt-type and assigns it into variable
>> altera_gc->interrupt_trigger . Note that if this property is not in the
>> DT, the driver will fail to probe.
>>
>> Clearly, there is a typo between altr,interrupt-trigger and
>> altr,interrupt-type . Since the driver fails to probe if altr,...-type
>> property is not present, there must be users of this variant in the
>> wild. I believe the Documentation/devicetree is a part of DT ABI, so the
>> bindings there should not be randomly changed.
>>
>> In this case, I would propose to change the Documentation though, since
>> any users who try to use altr,...-trigger will have probe failures and
>> fix their DT anyway.
>>
>> Does this make sense ? If so, I will submit a patch .
>>
>> Thanks!
>>
>
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2016-02-29 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 2:10 gpio-altera OF binding discrepancy Marek Vasut
2016-02-29 15:15 ` Tien Hock Loh
2016-02-29 16:22 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D4702B.1090205@denx.de \
--to=marex@denx.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=thloh85@gmail.com \
--cc=thloh@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox