From: Phil Reid <preid@electromag.com.au>
To: Marek Vasut <marex@denx.de>, linux-gpio@vger.kernel.org
Cc: Tien Hock Loh <thloh@altera.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] dt-bindings: gpio: altera: Fix altr,interrupt-type property
Date: Tue, 1 Mar 2016 09:22:49 +0800 [thread overview]
Message-ID: <56D4EEE9.3060308@electromag.com.au> (raw)
In-Reply-To: <1456762997-7607-1-git-send-email-marex@denx.de>
On 1/03/2016 12:23 AM, Marek Vasut wrote:
> The altr,interrupt-trigger property is not used by the driver.
> Instead, altr,interrupt-type is used by the driver and the driver
> does not probe if this property is not specified. Therefore, it
> is expected that there are no users of the -trigger property in
> the wild and that this is a typo in the documentation for the
> altera-pio controller. This patch fixes the typo.
>
On a related note. The Altera QSYS 15.0 device tree tools generate this label this as altr,interrupt_type
Note: '_' instead of '-'.
I've locally patch the driver to look for both names.
Not sure if this is something that should be fixed in the driver or require user to to post process the generated dts.
I haven't reported the issue to Altera either.
--
Regards
Phil Reid
next prev parent reply other threads:[~2016-03-01 1:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 16:23 [PATCH] dt-bindings: gpio: altera: Fix altr,interrupt-type property Marek Vasut
2016-03-01 1:22 ` Phil Reid [this message]
2016-03-01 1:29 ` Marek Vasut
2016-03-01 8:17 ` Tien Hock Loh
2016-03-01 13:49 ` Marek Vasut
2016-03-09 2:48 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D4EEE9.3060308@electromag.com.au \
--to=preid@electromag.com.au \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marex@denx.de \
--cc=thloh@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).