From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-renesas-soc@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms
Date: Mon, 7 Mar 2016 23:34:19 +0300 [thread overview]
Message-ID: <56DDE5CB.60204@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdWis_knSv0Lgw+8O3LXp9thEX3SdGX6qo_4UyFrxFVuHA@mail.gmail.com>
On 03/07/2016 11:29 PM, Geert Uytterhoeven wrote:
>>>> --- a/drivers/pinctrl/sh-pfc/core.c
>>>> +++ b/drivers/pinctrl/sh-pfc/core.c
>>>> @@ -545,7 +545,9 @@ static int sh_pfc_probe(struct platform_device *pdev)
>>>> return ret;
>>>> }
>>>>
>>>> - pinctrl_provide_dummies();
>>>> + /* Enable dummy states for those platforms without pinctrl
>>>> support */
>>>> + if (!of_have_populated_dt())
>>
>> I'd considered this condition -- it won't fly on SH where CONFIG_OF=n,
>> the kernel just won't build IIUC...
>
> I haven't tried to compile it yet, but <linux/of.h> does provide a dummy that
> returns false.
Oops, indeed. I missed it. :-(
This approach is better then, won't have to fix again whenever SH gets DT
support.
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
next prev parent reply other threads:[~2016-03-07 20:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 18:40 [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms Wolfram Sang
2016-03-07 19:56 ` Geert Uytterhoeven
2016-03-07 20:02 ` Sergei Shtylyov
2016-03-07 20:29 ` Geert Uytterhoeven
2016-03-07 20:34 ` Sergei Shtylyov [this message]
2016-03-07 21:00 ` Geert Uytterhoeven
2016-03-07 21:19 ` Sergei Shtylyov
2016-03-08 8:15 ` Geert Uytterhoeven
2016-03-07 22:21 ` Wolfram Sang
2016-03-09 10:30 ` Linus Walleij
2016-03-09 9:58 ` Wolfram Sang
2016-03-09 10:32 ` Linus Walleij
2016-03-09 12:51 ` Sergei Shtylyov
2016-03-09 15:37 ` Wolfram Sang
2016-03-09 13:17 ` Geert Uytterhoeven
2016-03-29 5:48 ` Shawn Guo
2016-03-15 8:29 ` Linus Walleij
2016-03-15 9:08 ` Geert Uytterhoeven
2016-03-15 12:31 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DDE5CB.60204@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).