From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms Date: Wed, 9 Mar 2016 15:51:09 +0300 Message-ID: <56E01C3D.1060600@cogentembedded.com> References: <1457376072-755-1-git-send-email-wsa@the-dreams.de> <56DDDE6E.6090908@cogentembedded.com> <56DDE5CB.60204@cogentembedded.com> <20160309095805.GA1506@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lb0-f180.google.com ([209.85.217.180]:36103 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753536AbcCIMvL (ORCPT ); Wed, 9 Mar 2016 07:51:11 -0500 Received: by mail-lb0-f180.google.com with SMTP id x1so63694735lbj.3 for ; Wed, 09 Mar 2016 04:51:10 -0800 (PST) In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij , Wolfram Sang Cc: Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org, Laurent Pinchart , Kuninori Morimoto , Magnus Damm , Geert Uytterhoeven , "linux-gpio@vger.kernel.org" , Shawn Guo , Sascha Hauer Hello. On 3/9/2016 1:32 PM, Linus Walleij wrote: >>>> This approach is better then, won't have to fix again whenever SH gets DT >>>> support. >>> >>> Perhaps the of_have_populated_dt() check should be moved inside >>> pinctrl_provide_dummies()? >> >> I suggest we pick up this patch now even with stable tag (the irq storm >> fixup doesn't work correctly because of this) and consider the >> refactoring as a second step? > > Sergei, Geert, do you ACK this? Since this patch fixes the real issue in mainline (which I wasn't aware of -- my patch only describes an issue with the 'ravb' driver the patches for using which in gen2 were never sent upstream): Acked-by: Sergei Shtylyov I'd only like that the "Fixes:" and "Cc:" tags were added to it. > Yours, > Linus Walleij MBR, Sergei