From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms Date: Tue, 15 Mar 2016 15:31:16 +0300 Message-ID: <56E80094.9070206@cogentembedded.com> References: <1457376072-755-1-git-send-email-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: Linus Walleij , Wolfram Sang Cc: linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart , Kuninori Morimoto , Magnus Damm , Geert Uytterhoeven , "linux-gpio@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On 3/15/2016 11:29 AM, Linus Walleij wrote: >> From: Wolfram Sang >> >> If pinctrl_provide_dummies() is used unconditionally, then the dummy >> state will be used even on DT platforms when the "init" state was >> intentionally left out. Instead of "default", the dummy "init" state >> will then be used during probe. Thus, when probing an I2C controller on >> cold boot, communication triggered by bus notifiers broke because the >> pins were not initialized. >> >> Do it like OMAP2: use the dummy state only for non-DT platforms. >> >> Reported-by: Geert Uytterhoeven >> Signed-off-by: Wolfram Sang > > Patch applied for fixes with all the ACKs etc. > > This unfortiunately coincide with the merge window so was slow > to pick it up, but it will be in the first round of fixes to Torvalds, > possibly at -rc1 possibly earlier. TIA! >> - pinctrl_provide_dummies(); >> + /* Enable dummy states for those platforms without pinctrl support */ >> + if (!of_have_populated_dt()) >> + pinctrl_provide_dummies(); > > So remind we: what Renesas platforms are still not using DT? > arch/sh? Yes, only those are left. > Yours, > Linus Walleij MBR, Sergei