* [PATCH v2] gpio: pca953x: Use correct u16 value for register word write
@ 2016-03-30 6:49 Yong Li
2016-03-31 3:28 ` Phil Reid
2016-04-01 12:51 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Yong Li @ 2016-03-30 6:49 UTC (permalink / raw)
To: linus.walleij, gnurou, linux-gpio, linux-kernel, alexander.stein,
preid
Cc: sdliyong
The current implementation only uses the first byte in val,
the second byte is always 0. Change it to use cpu_to_le16
to write the two bytes into the register
Signed-off-by: Yong Li <sdliyong@gmail.com>
---
drivers/gpio/gpio-pca953x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index d0d3065..e66084c 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -18,6 +18,7 @@
#include <linux/i2c.h>
#include <linux/platform_data/pca953x.h>
#include <linux/slab.h>
+#include <asm/unaligned.h>
#include <linux/of_platform.h>
#include <linux/acpi.h>
@@ -159,7 +160,7 @@ static int pca953x_write_regs(struct pca953x_chip *chip, int reg, u8 *val)
switch (chip->chip_type) {
case PCA953X_TYPE:
ret = i2c_smbus_write_word_data(chip->client,
- reg << 1, (u16) *val);
+ reg << 1, cpu_to_le16(get_unaligned((u16 *)val)));
break;
case PCA957X_TYPE:
ret = i2c_smbus_write_byte_data(chip->client, reg << 1,
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write
2016-03-30 6:49 [PATCH v2] gpio: pca953x: Use correct u16 value for register word write Yong Li
@ 2016-03-31 3:28 ` Phil Reid
2016-04-01 12:51 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Phil Reid @ 2016-03-31 3:28 UTC (permalink / raw)
To: Yong Li, linus.walleij, gnurou, linux-gpio, linux-kernel,
alexander.stein
On 30/03/2016 2:49 PM, Yong Li wrote:
> The current implementation only uses the first byte in val,
> the second byte is always 0. Change it to use cpu_to_le16
> to write the two bytes into the register
>
> Signed-off-by: Yong Li <sdliyong@gmail.com>
Reviewed-by: Phil Reid <preid@electromag.com.au>
> ---
> drivers/gpio/gpio-pca953x.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index d0d3065..e66084c 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -18,6 +18,7 @@
> #include <linux/i2c.h>
> #include <linux/platform_data/pca953x.h>
> #include <linux/slab.h>
> +#include <asm/unaligned.h>
> #include <linux/of_platform.h>
> #include <linux/acpi.h>
>
> @@ -159,7 +160,7 @@ static int pca953x_write_regs(struct pca953x_chip *chip, int reg, u8 *val)
> switch (chip->chip_type) {
> case PCA953X_TYPE:
> ret = i2c_smbus_write_word_data(chip->client,
> - reg << 1, (u16) *val);
> + reg << 1, cpu_to_le16(get_unaligned((u16 *)val)));
> break;
> case PCA957X_TYPE:
> ret = i2c_smbus_write_byte_data(chip->client, reg << 1,
>
--
Regards
Phil Reid
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write
2016-03-30 6:49 [PATCH v2] gpio: pca953x: Use correct u16 value for register word write Yong Li
2016-03-31 3:28 ` Phil Reid
@ 2016-04-01 12:51 ` Linus Walleij
2016-04-01 14:38 ` Yong Li
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2016-04-01 12:51 UTC (permalink / raw)
To: Yong Li
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Alexander Stein, Phil Reid
On Wed, Mar 30, 2016 at 8:49 AM, Yong Li <sdliyong@gmail.com> wrote:
> The current implementation only uses the first byte in val,
> the second byte is always 0. Change it to use cpu_to_le16
> to write the two bytes into the register
>
> Signed-off-by: Yong Li <sdliyong@gmail.com>
Patch applied to fixes with Phil's review tag.
It is a regression, right?
Should it be tagged for stable?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write
2016-04-01 12:51 ` Linus Walleij
@ 2016-04-01 14:38 ` Yong Li
0 siblings, 0 replies; 4+ messages in thread
From: Yong Li @ 2016-04-01 14:38 UTC (permalink / raw)
To: Linus Walleij
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Alexander Stein, Phil Reid
Yes it is a regression. I think it should be tagged for stable too
Thanks,
Yong
2016-04-01 20:51 GMT+08:00 Linus Walleij <linus.walleij@linaro.org>:
> On Wed, Mar 30, 2016 at 8:49 AM, Yong Li <sdliyong@gmail.com> wrote:
>
>> The current implementation only uses the first byte in val,
>> the second byte is always 0. Change it to use cpu_to_le16
>> to write the two bytes into the register
>>
>> Signed-off-by: Yong Li <sdliyong@gmail.com>
>
> Patch applied to fixes with Phil's review tag.
>
> It is a regression, right?
>
> Should it be tagged for stable?
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-01 14:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-30 6:49 [PATCH v2] gpio: pca953x: Use correct u16 value for register word write Yong Li
2016-03-31 3:28 ` Phil Reid
2016-04-01 12:51 ` Linus Walleij
2016-04-01 14:38 ` Yong Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).