From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E15E92FE06B for ; Fri, 12 Dec 2025 16:49:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765558204; cv=none; b=Lo66cMLkMjlJkUOjXx//CJ6kesuslYlE6Lyt7OfJQoSP7syJA3GqObNxZUlLHYe8+G4d14tivQnNd/3PqMlweO90AGGLpYJi8ePt1RKqhSqumIJFDWL26wqpmyXjDsRJsO773kdkflW4OO1tGDAYvE6fQLSqPBHi8idQAy9GWfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765558204; c=relaxed/simple; bh=UfTqUYVlH6JJezxE02WMaTDMov6J1EqwxG6wSFYCvwQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=dwJvf2NupYSy73L8KJaICieTv6A8+ZevWukYeXkv5YIQdabiFyi4zp6JfPbJy+mUnutoC4Jdg7RgXfNkcxP3orVzdSCfufWRQoF1xX0W6Zjd/OEUbffZJ28rr/195iO75BiwhU1TqDlajqsTqDKfDoJ67PQO8Y3sKUZucNIKBr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lzn2AuVY; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lzn2AuVY" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-477aa218f20so10116045e9.0 for ; Fri, 12 Dec 2025 08:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765558198; x=1766162998; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=PZPqbz7TOBgko/Hla8XUW3S+0lBGp/7OqAvJDlub6lU=; b=lzn2AuVY26gwdImNQfRlIKlo2ZJRSDSf+KinFLyyWmuRm1jV8ujEDboElOm4Od9F6c 0CcVlL+FQYOFQIxomfwTNDvsZIgtvjnhDNl7NlrDumdVdLUIsuIiAIpNLzgJcYenx2uR iWomIpjcFEI8AYRic1Tb7hq9vjkRKEkiMpcCdUc9DCXm7mw4HNJVh/Yu/zwVpfcTQdXU so0Qww8IKbekpHgtXPUOwGkSyOJqDvLS2oUQOs3jNRrKaNjv7dGsGo5SMbMV5dlXqOcc KBr9J9cKEIa5MyVbQzk3AUtbu9tZIwzqol8o7YQaGt9Iv5pLgbhYIR+aW8ZGNaCo03nR dMhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765558198; x=1766162998; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PZPqbz7TOBgko/Hla8XUW3S+0lBGp/7OqAvJDlub6lU=; b=m4mDmhSpbWR/8/+QQv1B8xxciBVhlze7geGlTni/XZb99NM1YkufwBl1t9Q5s7T6Pw NP/qwkgaJfc3wcUCmCSZMDN6p2eFrXOMxjYjp1Dx0lgWecMEqQKcceDYhJ57zbws5yAS tArp7V/zQ/ZWtaczFnrhcOmBsHRPCroACSn2LeyfGBUSQOEDjwXW2lGKloQ/+a8YKoXb 3LsfLXooq4KOGPKzkXcj3H4/ZYvk0NqhKDhnbhggnPVJwd6npT63CENF164Zwccq4FgY EaV7qnQneiHKES5Gnry1Io8xxA0iFs42uKYkm8LCDMcaTTmqly1x9ZkssMz/2B0ZzU+H 6C9A== X-Forwarded-Encrypted: i=1; AJvYcCXsOxr4SGi23Rr5b5TsXFpLXP2/Cr1VFaFvCNKf0d43RjYc5zrZgOJt/6IJxP8X+nx+DztriT/s5xwK@vger.kernel.org X-Gm-Message-State: AOJu0Yzd3yH2cSaYlnfzk6BcCQGgSCk+22f9reqrfZU9drgCQDEeyALO ZAGuY+7aElbpX5HEbNloI7PUlfat6EkkRMQLjktfkC5WDAARCG2MyUTZ X-Gm-Gg: AY/fxX5Eo5hhBF2YTaBzYG/tQEPUIJviq1Z8Z4qqqsmPulAEORzEO/WImmftZrheQQh IRrMtUGqqWSGMoTgb3ujEOsiIbEgx2qJ/MbktBldkMNEEJ2gUBPc21JefsNy6oZzNvWgQ0L3pSB btFreY2wJurMGAslADdsjd6XAtzLAo8HbFlnagFUyXyV7zAB/cJtTELtsnIgyn6OKugNFZAfIGP VQaKp32wMDgxVX4gjvI/TPr5uob5SiXDcRzryDMqB15GccjQ+rG9JMZAZWqLn7ZSDFyhjQHwIZk xziXo/hjGVb5CVnAGb7wBeY73wqYXW2y+dYgOgfW6NZrsuF3J5/NAvofCI3a7rlTXgrRQWTjkFj rRrSxkrz+HaYVDM+hyctMcedjaTPk+JtGTb+aObVWKzS2qqtUADUSJgXAbPEoz2Vlauv/E1VA8K QeKLoIgEOOhmJOSKy1rqQ= X-Google-Smtp-Source: AGHT+IHtZMgglKAk4R8+0M+7aDLFMijPt5gozxzmISoQwpRsEMx37DIzleuM9f/I4lIUnptB6FxMbg== X-Received: by 2002:a05:600c:4f84:b0:477:7b16:5f88 with SMTP id 5b1f17b1804b1-47a8f8a7f7amr31251535e9.6.1765558197375; Fri, 12 Dec 2025 08:49:57 -0800 (PST) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f6f3a46sm42566015e9.15.2025.12.12.08.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Dec 2025 08:49:57 -0800 (PST) Message-ID: <56a6c6a1b800090522a61eea5141aa8c986faea1.camel@gmail.com> Subject: Re: [PATCH v4 2/3] hwmon: ltc4283: Add support for the LTC4283 Swap Controller From: Nuno =?ISO-8859-1?Q?S=E1?= To: Guenter Roeck , nuno.sa@analog.com, linux-hwmon@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Cc: Krzysztof Kozlowski , Conor Dooley , Jean Delvare , Jonathan Corbet , Linus Walleij , Bartosz Golaszewski Date: Fri, 12 Dec 2025 16:50:37 +0000 In-Reply-To: References: <20251204-ltc4283-support-v4-0-db0197fd7984@analog.com> <20251204-ltc4283-support-v4-2-db0197fd7984@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2025-12-11 at 09:56 -0800, Guenter Roeck wrote: > On 12/4/25 08:15, Nuno S=C3=A1 via B4 Relay wrote: > > From: Nuno S=C3=A1 > >=20 > > Support the LTC4283 How Swap Controller. The device features programmab= le > > current limit with foldback and independently adjustable inrush current= to > > optimize the MOSFET safe operating area (SOA). The SOA timer limits MOS= FET > > temperature rise for reliable protection against overstresses. > >=20 > > An I2C interface and onboard ADC allow monitoring of board current, > > voltage, power, energy, and fault status. > >=20 > > Signed-off-by: Nuno S=C3=A1 > > --- > ... > > diff --git a/drivers/hwmon/ltc4283.c b/drivers/hwmon/ltc4283.c > > new file mode 100644 > > index 000000000000..d79432678b84 > > --- /dev/null > > +++ b/drivers/hwmon/ltc4283.c > ... > > + > > +static int ltc4283_read_voltage_word(const struct ltc4283_hwmon *st, > > + =C2=A0=C2=A0=C2=A0=C2=A0 u32 reg, u32 fs, long *val) > > +{ > > + __be16 in; > > + int ret; > > + > > + ret =3D regmap_bulk_read(st->map, reg, &in, sizeof(in)); >=20 > I had a look into the regmap code. In its current implementation, > that will work as long as > 1) regmap is configured to not cache anything > 2) the I2C controller supports I2C_FUNC_SMBUS_I2C_BLOCK >=20 Possibly dumb question... what would be the issue about doing multiple regmap reads if we can't do the bulk?=C2=A0That would be my naive approach = in the driver if I'm not going to use the bulk API. - Nuno S=C3=A1