From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [patch] gpio: brcmstb: missing error code Date: Fri, 15 Apr 2016 15:04:20 -0700 Message-ID: <57116564.4000002@gmail.com> References: <20160415144528.GC8953@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160415144528.GC8953@mwanda> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter , Gregory Fong Cc: Linus Walleij , Alexandre Courbot , Brian Norris , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-gpio@vger.kernel.org On 15/04/16 07:45, Dan Carpenter wrote: > We should set the error code before returning here. Otherwise "err" > could be uninitialized or zero. > > Signed-off-by: Dan Carpenter Axel just sent an identical patch which Linus picked already: http://www.spinics.net/lists/linux-gpio/msg13728.html Thanks Dan! -- Florian