From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrice Chotard Subject: Re: [PATCH 6/8] mfd: Add STMPE1600 support Date: Thu, 21 Apr 2016 15:51:40 +0200 Message-ID: <5718DAEC.6030207@st.com> References: <1461068317-28016-1-git-send-email-patrice.chotard@st.com> <1461068317-28016-7-git-send-email-patrice.chotard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Lee Jones , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Maxime Coquelin , amelie.delaunay@st.com, Shawn Guo , Sascha Hauer , Dinh Nguyen , Viresh Kumar , Shiraz Hashim , Stephen Warren , Thierry Reding List-Id: linux-gpio@vger.kernel.org On 04/20/2016 04:43 PM, Linus Walleij wrote: > On Tue, Apr 19, 2016 at 2:18 PM, wrote: > >> From: Patrice Chotard >> >> STMPE1600 is a 16-bit port expander. >> Datasheet is available here : >> http://www2.st.com/content/st_com/en/products/interfaces-and-transceivers/ >> i-o-expanders-and-level-translators/i-o-expanders/stmpe1600.html >> >> As STMPE1600's SYS_CTRL register has the same layout as >> STMPE801 variant, unify STMPExxx_REG_SYS_CTRL_RESET/INT_EN/INT_HI >> bit masks to more generic STMPE_SYS_CTRL_RESET/INT_EN/INT_HI >> >> Signed-off-by: Amelie DELAUNAY >> Signed-off-by: Patrice Chotard > (...) >> #define STMPE_SYS_CTRL_RESET (1 << 7) >> +#define STMPE_SYS_CTRL_INT_EN (1 << 2) >> +#define STMPE_SYS_CTRL_INT_HI (1 << 0) >> >> /* >> * STMPE801 >> @@ -121,10 +123,6 @@ int stmpe_remove(struct stmpe *stmpe); >> #define STMPE801_REG_GPIO_SET_PIN 0x11 >> #define STMPE801_REG_GPIO_DIR 0x12 >> >> -#define STMPE801_REG_SYS_CTRL_RESET (1 << 7) >> -#define STMPE801_REG_SYS_CTRL_INT_EN (1 << 2) >> -#define STMPE801_REG_SYS_CTRL_INT_HI (1 << 0) > This looks like unrelated cleanups? > Should this be in the reset enablement patch? > (It's OK with me though.) Not completely unrelated as STMPE801 and STMPE1600 use the same SYS_CTRL register layout. But nevertheless i will put this fix in a separate patch. Thanks Patrice > > With that fixed: > Acked-by: Linus Walleij > > Yours, > Linus Walleij Hi