From: Neil Armstrong <narmstrong@baylibre.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] pinctrl: Add Oxford Semiconductor OXNAS pinctrl and gpio driver
Date: Tue, 24 May 2016 11:37:15 +0200 [thread overview]
Message-ID: <574420CB.30908@baylibre.com> (raw)
In-Reply-To: <CACRpkdZPMqRNn9rmcC4HYVKrdS7cxBD7O7oE4YPrP7L-0_Wakg@mail.gmail.com>
On 05/24/2016 11:35 AM, Linus Walleij wrote:
> On Wed, May 11, 2016 at 9:34 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>
>> Add pinctrl and gpio control support to Oxford Semiconductor OXNAS SoC Family.
>> This version supports the ARM926EJ-S based OX810SE SoC with 34 IO pins.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>
> I tried implementing a .get_direction() callback for the Oxnas GPIO
> (this is good to have, for debugfs and for the new userspace ABI).
>
> However:
>
>> +/* GPIO Registers */
>> +#define INPUT_VALUE 0x00
>> +#define IRQ_PENDING 0x0c
>> +#define OUTPUT_SET 0x14
>> +#define OUTPUT_CLEAR 0x18
>> +#define OUTPUT_EN_SET 0x1c
>> +#define OUTPUT_EN_CLEAR 0x20
>> +#define RE_IRQ_ENABLE 0x28
>> +#define FE_IRQ_ENABLE 0x2c
>
> No pure OUTPUT_EN register to read the direction from?
> Or is it one of the undocumented ones?
I'm not sure it was documented, I can have a look further.
>
> Could you take a stab at implementing .get_direction() and
> send a patch?
I can have a look ASAP.
Neil
>
> Yours,
> Linus Walleij
>
next prev parent reply other threads:[~2016-05-24 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 7:34 [PATCH v2 0/2] pinctrl: Oxford Semiconductor OXNAS pinctrl and gpio support Neil Armstrong
2016-05-11 7:34 ` [PATCH v2 1/2] pinctrl: Add Oxford Semiconductor OXNAS pinctrl and gpio driver Neil Armstrong
2016-05-24 9:28 ` Linus Walleij
2016-05-24 9:35 ` Linus Walleij
2016-05-24 9:37 ` Neil Armstrong [this message]
2016-05-11 7:34 ` [PATCH v2 2/2] dt-bindings: Add Oxford Semiconductor OXNAS pinctrl and gpio bindings Neil Armstrong
2016-05-16 14:52 ` Rob Herring
2016-05-24 9:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574420CB.30908@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).