* [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking
@ 2017-11-30 14:12 Arvind Yadav
2017-12-02 15:30 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Arvind Yadav @ 2017-11-30 14:12 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-kernel, linux-gpio
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/gpio/gpio-ftgpio010.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
index 7b3394f..feff86a 100644
--- a/drivers/gpio/gpio-ftgpio010.c
+++ b/drivers/gpio/gpio-ftgpio010.c
@@ -176,8 +176,8 @@ static int ftgpio_gpio_probe(struct platform_device *pdev)
return PTR_ERR(g->base);
irq = platform_get_irq(pdev, 0);
- if (!irq)
- return -EINVAL;
+ if (irq < 0)
+ return irq;
ret = bgpio_init(&g->gc, dev, 4,
g->base + GPIO_DATA_IN,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking
2017-11-30 14:12 [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking Arvind Yadav
@ 2017-12-02 15:30 ` Linus Walleij
2017-12-02 16:49 ` arvindY
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2017-12-02 15:30 UTC (permalink / raw)
To: Arvind Yadav; +Cc: linux-kernel@vger.kernel.org, linux-gpio
Hi Arvind,
thanks for the patch!
On Thu, Nov 30, 2017 at 3:12 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
(...)
> irq = platform_get_irq(pdev, 0);
> - if (!irq)
> - return -EINVAL;
> + if (irq < 0)
> + return irq;
This is wrong.
For an in-depth explanation why irq 0 in not valid, see:
https://lwn.net/Articles/470820/
It should be:
if (irq <= 0)
return irq ? irq : -EINVAL;
Please update and resubmit. If you have more patches like this,
correct them too.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking
2017-12-02 15:30 ` Linus Walleij
@ 2017-12-02 16:49 ` arvindY
0 siblings, 0 replies; 3+ messages in thread
From: arvindY @ 2017-12-02 16:49 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-kernel@vger.kernel.org, linux-gpio
Hi Linus,
On Saturday 02 December 2017 09:00 PM, Linus Walleij wrote:
> Hi Arvind,
>
> thanks for the patch!
>
> On Thu, Nov 30, 2017 at 3:12 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
>
>> The platform_get_irq() function returns negative if an error occurs.
>> zero or positive number on success. platform_get_irq() error checking
>> for zero is not correct.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> (...)
>> irq = platform_get_irq(pdev, 0);
>> - if (!irq)
>> - return -EINVAL;
>> + if (irq < 0)
>> + return irq;
> This is wrong.
> For an in-depth explanation why irq 0 in not valid, see:
> https://lwn.net/Articles/470820/
Thank you for sharing this Articles. It's really helpful.
>
> It should be:
>
> if (irq <= 0)
> return irq ? irq : -EINVAL;
>
> Please update and resubmit. If you have more patches like this,
> correct them too.
I will resubmit patch.
> Yours,
> Linus Walleij
Thanks,
arvind
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-02 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-30 14:12 [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking Arvind Yadav
2017-12-02 15:30 ` Linus Walleij
2017-12-02 16:49 ` arvindY
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).