From: Doug Berger <opendmb@gmail.com>
To: Yang Li <yang.lee@linux.alibaba.com>, linus.walleij@linaro.org
Cc: brgl@bgdev.pl, f.fainelli@gmail.com,
bcm-kernel-feedback-list@broadcom.com,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource()
Date: Fri, 28 Apr 2023 11:51:39 -0700 [thread overview]
Message-ID: <5be7e9de-a81b-c0c8-2231-06144ff3cdea@gmail.com> (raw)
In-Reply-To: <20230428061109.102343-1-yang.lee@linux.alibaba.com>
On 4/27/2023 11:11 PM, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpio/gpio-brcmstb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index c55b35da61a0..6566517fe0d8 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, priv);
> INIT_LIST_HEAD(&priv->bank_list);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - reg_base = devm_ioremap_resource(dev, res);
> + reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(reg_base))
> return PTR_ERR(reg_base);
>
Acked-by: Doug Berger <opendmb@gmail.com>
next prev parent reply other threads:[~2023-04-28 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 6:11 [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-04-28 17:42 ` Florian Fainelli
2023-04-28 18:51 ` Doug Berger [this message]
2023-05-08 13:31 ` Linus Walleij
2023-05-23 8:24 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5be7e9de-a81b-c0c8-2231-06144ff3cdea@gmail.com \
--to=opendmb@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).