* [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource()
@ 2023-04-28 6:11 Yang Li
2023-04-28 17:42 ` Florian Fainelli
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Yang Li @ 2023-04-28 6:11 UTC (permalink / raw)
To: linus.walleij
Cc: brgl, opendmb, f.fainelli, bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel, linux-kernel, Yang Li
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpio/gpio-brcmstb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index c55b35da61a0..6566517fe0d8 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, priv);
INIT_LIST_HEAD(&priv->bank_list);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- reg_base = devm_ioremap_resource(dev, res);
+ reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(reg_base))
return PTR_ERR(reg_base);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource()
2023-04-28 6:11 [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource() Yang Li
@ 2023-04-28 17:42 ` Florian Fainelli
2023-04-28 18:51 ` Doug Berger
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2023-04-28 17:42 UTC (permalink / raw)
To: Yang Li, linus.walleij
Cc: brgl, opendmb, f.fainelli, bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel, linux-kernel
On 4/27/23 23:11, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource()
2023-04-28 6:11 [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-04-28 17:42 ` Florian Fainelli
@ 2023-04-28 18:51 ` Doug Berger
2023-05-08 13:31 ` Linus Walleij
2023-05-23 8:24 ` Bartosz Golaszewski
3 siblings, 0 replies; 5+ messages in thread
From: Doug Berger @ 2023-04-28 18:51 UTC (permalink / raw)
To: Yang Li, linus.walleij
Cc: brgl, f.fainelli, bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel, linux-kernel
On 4/27/2023 11:11 PM, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpio/gpio-brcmstb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index c55b35da61a0..6566517fe0d8 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, priv);
> INIT_LIST_HEAD(&priv->bank_list);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - reg_base = devm_ioremap_resource(dev, res);
> + reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(reg_base))
> return PTR_ERR(reg_base);
>
Acked-by: Doug Berger <opendmb@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource()
2023-04-28 6:11 [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-04-28 17:42 ` Florian Fainelli
2023-04-28 18:51 ` Doug Berger
@ 2023-05-08 13:31 ` Linus Walleij
2023-05-23 8:24 ` Bartosz Golaszewski
3 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2023-05-08 13:31 UTC (permalink / raw)
To: Yang Li
Cc: brgl, opendmb, f.fainelli, bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel, linux-kernel
On Fri, Apr 28, 2023 at 8:11 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Looks good
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource()
2023-04-28 6:11 [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource() Yang Li
` (2 preceding siblings ...)
2023-05-08 13:31 ` Linus Walleij
@ 2023-05-23 8:24 ` Bartosz Golaszewski
3 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2023-05-23 8:24 UTC (permalink / raw)
To: Yang Li
Cc: linus.walleij, opendmb, f.fainelli, bcm-kernel-feedback-list,
linux-gpio, linux-arm-kernel, linux-kernel
On Fri, Apr 28, 2023 at 8:11 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpio/gpio-brcmstb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index c55b35da61a0..6566517fe0d8 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, priv);
> INIT_LIST_HEAD(&priv->bank_list);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - reg_base = devm_ioremap_resource(dev, res);
> + reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(reg_base))
> return PTR_ERR(reg_base);
>
> --
> 2.20.1.7.g153144c
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-23 8:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-28 6:11 [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-04-28 17:42 ` Florian Fainelli
2023-04-28 18:51 ` Doug Berger
2023-05-08 13:31 ` Linus Walleij
2023-05-23 8:24 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).