From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Jeremy Kerr" <jk@codeconstruct.com.au>, "Joel Stanley" <joel@jms.id.au>
Cc: linux-gpio@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] gpio/aspeed-sgpio: enable access to all 80 input & output sgpios
Date: Fri, 11 Sep 2020 12:58:06 +0930 [thread overview]
Message-ID: <5beba404-14f0-4bb1-9110-c110797d5a04@www.fastmail.com> (raw)
In-Reply-To: <20200911015105.48581-1-jk@codeconstruct.com.au>
On Fri, 11 Sep 2020, at 11:21, Jeremy Kerr wrote:
> Currently, the aspeed-sgpio driver exposes up to 80 GPIO lines,
> corresponding to the 80 status bits available in hardware. Each of these
> lines can be configured as either an input or an output.
>
> However, each of these GPIOs is actually an input *and* an output; we
> actually have 80 inputs plus 80 outputs.
>
> This change expands the maximum number of GPIOs to 160; the lower half
> of this range are the input-only GPIOs, the upper half are the outputs.
> We fix the GPIO directions to correspond to this mapping.
>
> This also fixes a bug when setting GPIOs - we were reading from the
> input register, making it impossible to set more than one output GPIO.
>
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
> Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
This was something I was leaning on the implementer to sort out when I
reviewed the driver way back. Oh well.
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
next prev parent reply other threads:[~2020-09-11 3:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 1:51 [PATCH v2 1/2] gpio/aspeed-sgpio: enable access to all 80 input & output sgpios Jeremy Kerr
2020-09-11 1:51 ` [PATCH v2 2/2] gpio/aspeed-sgpio: don't enable all interrupts by default Jeremy Kerr
2020-09-11 2:21 ` Joel Stanley
2020-09-11 3:29 ` Andrew Jeffery
2020-09-11 2:20 ` [PATCH v2 1/2] gpio/aspeed-sgpio: enable access to all 80 input & output sgpios Joel Stanley
2020-09-16 4:51 ` Joel Stanley
2020-09-16 11:09 ` Bartosz Golaszewski
2020-09-16 12:59 ` Joel Stanley
2020-09-24 13:11 ` Bartosz Golaszewski
2020-09-11 3:28 ` Andrew Jeffery [this message]
2020-09-22 22:39 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5beba404-14f0-4bb1-9110-c110797d5a04@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).