linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: Tony Lindgren <tony@atomide.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: Regression in next with gpiolib
Date: Wed, 30 Aug 2017 16:49:43 -0500	[thread overview]
Message-ID: <5c672146-2a4c-6da5-85b1-5f2bb2ae5649@codeaurora.org> (raw)
In-Reply-To: <20170830214127.GJ6008@atomide.com>

On 08/30/2017 04:41 PM, Tony Lindgren wrote:
> It seems to be that we're now calling request and free on all gpios
> before they are properly configured?

Yes, that's what my patch does.  At the time, it seemed like a good idea 
-- request the GPIO before touching its hardware.  But it appears that 
the 'request' function of some drivers also re-muxes the GPIO in order 
to honor the request.

The question is whether that's correct behavior.  I don't know.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2017-08-30 21:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 21:41 Regression in next with gpiolib Tony Lindgren
2017-08-30 21:49 ` Timur Tabi [this message]
2017-08-31  5:59 ` Linus Walleij
2017-08-31 14:02   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c672146-2a4c-6da5-85b1-5f2bb2ae5649@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).