From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: Regression in next with gpiolib Date: Wed, 30 Aug 2017 16:49:43 -0500 Message-ID: <5c672146-2a4c-6da5-85b1-5f2bb2ae5649@codeaurora.org> References: <20170830214127.GJ6008@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:44070 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdH3Vtp (ORCPT ); Wed, 30 Aug 2017 17:49:45 -0400 In-Reply-To: <20170830214127.GJ6008@atomide.com> Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Tony Lindgren , Linus Walleij , Grygorii Strashko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org On 08/30/2017 04:41 PM, Tony Lindgren wrote: > It seems to be that we're now calling request and free on all gpios > before they are properly configured? Yes, that's what my patch does. At the time, it seemed like a good idea -- request the GPIO before touching its hardware. But it appears that the 'request' function of some drivers also re-muxes the GPIO in order to honor the request. The question is whether that's correct behavior. I don't know. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.