From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sricharan Ramabadhran <quic_srichara@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, ulf.hansson@linaro.org,
linus.walleij@linaro.org, catalin.marinas@arm.com,
will@kernel.org, p.zabel@pengutronix.de,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Nitheesh Sekar <quic_nsekar@quicinc.com>,
Varadarajan Narayanan <quic_varada@quicinc.com>
Subject: Re: [PATCH V3 3/9] dt-bindings: pinctrl: qcom: Add support for ipq5018
Date: Mon, 17 Apr 2023 08:22:20 +0200 [thread overview]
Message-ID: <5d4d02ec-f8e7-c931-aebe-6255209fbde0@linaro.org> (raw)
In-Reply-To: <9e977da8-902a-74d2-7cce-74669b127c30@quicinc.com>
On 17/04/2023 08:13, Sricharan Ramabadhran wrote:
>>> + tlmm: pinctrl@1000000 {
>>> + compatible = "qcom,ipq5018-tlmm";
>>> + reg = <0x01000000 0x300000>;
>>> + gpio-controller;
>>> + #gpio-cells = <2>;
>>> + gpio-ranges = <&tlmm 0 0 47>;
>>> + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
>>> + interrupt-controller;
>>> + #interrupt-cells = <2>;
>>> +
>>> + uart2-state {
>>> + pins = "gpio34", "gpio35";
>>> + function = "blsp2_uart";
>>
>> Does not look like you tested the bindings. Please run `make
>> dt_binding_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>
> I ran it against the TOT, will run it this time on nxt and post V4.
I don't know what is TOT, but this would fail in every case on every tree.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-17 6:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 10:29 [PATCH V3 0/9] Add minimal boot support for IPQ5018 Sricharan Ramabadhran
2023-04-14 10:29 ` [PATCH V3 1/9] dt-bindings: arm64: Add IPQ5018 clock and reset Sricharan Ramabadhran
2023-04-16 9:01 ` Krzysztof Kozlowski
2023-04-14 10:29 ` [PATCH V3 2/9] clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018 Sricharan Ramabadhran
2023-04-14 11:29 ` Konrad Dybcio
2023-04-14 12:18 ` Sricharan Ramabadhran
2023-04-14 10:29 ` [PATCH V3 3/9] dt-bindings: pinctrl: qcom: Add support for ipq5018 Sricharan Ramabadhran
2023-04-14 12:37 ` Rob Herring
2023-04-16 9:05 ` Krzysztof Kozlowski
2023-04-17 6:13 ` Sricharan Ramabadhran
2023-04-17 6:22 ` Krzysztof Kozlowski [this message]
2023-04-14 10:29 ` [PATCH V3 4/9] pinctrl: qcom: Add IPQ5018 pinctrl driver Sricharan Ramabadhran
2023-04-14 10:29 ` [PATCH V3 5/9] dt-bindings: qcom: Add ipq5018 bindings Sricharan Ramabadhran
2023-04-16 9:05 ` Krzysztof Kozlowski
2023-04-17 6:13 ` Sricharan Ramabadhran
2023-04-16 9:12 ` Krzysztof Kozlowski
2023-04-14 10:29 ` [PATCH V3 6/9] dt-bindings: firmware: document IPQ5018 SCM Sricharan Ramabadhran
2023-04-16 9:06 ` Krzysztof Kozlowski
2023-04-17 6:14 ` Sricharan Ramabadhran
2023-04-14 10:29 ` [PATCH V3 7/9] dt-bindings: mmc: sdhci-msm: Document the IPQ5018 compatible Sricharan Ramabadhran
2023-04-16 9:08 ` Krzysztof Kozlowski
2023-04-17 14:54 ` Ulf Hansson
2023-04-14 10:29 ` [PATCH V3 8/9] arm64: dts: Add ipq5018 SoC and rdp432-c2 board support Sricharan Ramabadhran
2023-04-14 11:31 ` Konrad Dybcio
2023-04-17 6:02 ` Sricharan Ramabadhran
2023-04-16 9:15 ` Krzysztof Kozlowski
2023-04-14 10:29 ` [PATCH V3 9/9] arm64: defconfig: Enable IPQ5018 SoC base configs Sricharan Ramabadhran
2023-04-16 9:07 ` [PATCH V3 0/9] Add minimal boot support for IPQ5018 Krzysztof Kozlowski
2023-04-17 4:50 ` Sricharan Ramabadhran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d4d02ec-f8e7-c931-aebe-6255209fbde0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_nsekar@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).