From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Alexandre Courbot <acourbot@nvidia.com>,
Stephen Warren <swarren@nvidia.com>,
linux-gpio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: gpio: fix bindings document
Date: Thu, 15 Jan 2015 16:00:31 +0200 [thread overview]
Message-ID: <6060230.fRgRe49Afg@avalon> (raw)
In-Reply-To: <1421311960-4120-1-git-send-email-yamada.m@jp.panasonic.com>
Hi Yamada-san,
Thank you for the patch.
On Thursday 15 January 2015 17:52:40 Masahiro Yamada wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> Documentation/devicetree/bindings/gpio/gpio.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt
> b/Documentation/devicetree/bindings/gpio/gpio.txt index b9bd1d6..f7a158d
> 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio.txt
> @@ -69,7 +69,8 @@ GPIO pin number, and GPIO flags as accepted by the
> "qe_pio_e" gpio-controller. ----------------------------------
>
> A gpio-specifier should contain a flag indicating the GPIO polarity;
> active- -high or active-low. If it does, the follow best practices should
> be followed: +high or active-low. If it does, the following best practices
> should be +followed:
>
> The gpio-specifier's polarity flag should represent the physical level at
> the GPIO controller that achieves (or represents, for inputs) a logically
> asserted @@ -147,7 +148,7 @@ contains information structures as follows:
> numeric-gpio-range ::=
> <pinctrl-phandle> <gpio-base> <pinctrl-base> <count>
> named-gpio-range ::= <pinctrl-phandle> <gpio-base> '<0 0>'
> - gpio-phandle : phandle to pin controller node.
> + pinctrl-phandle : phandle to pin controller node
> gpio-base : Base GPIO ID in the GPIO controller
> pinctrl-base : Base pinctrl pin ID in the pin controller
> count : The number of GPIOs/pins in this range
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-01-15 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 8:52 [PATCH] Documentation: gpio: fix bindings document Masahiro Yamada
2015-01-15 14:00 ` Laurent Pinchart [this message]
2015-01-15 14:07 ` Rob Herring
2015-01-15 14:10 ` Laurent Pinchart
2015-01-16 1:20 ` Masahiro Yamada
2015-01-19 10:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6060230.fRgRe49Afg@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=acourbot@nvidia.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@nvidia.com \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).