From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] Documentation: gpio: fix bindings document Date: Thu, 15 Jan 2015 16:00:31 +0200 Message-ID: <6060230.fRgRe49Afg@avalon> References: <1421311960-4120-1-git-send-email-yamada.m@jp.panasonic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:51440 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbbAOOAF (ORCPT ); Thu, 15 Jan 2015 09:00:05 -0500 In-Reply-To: <1421311960-4120-1-git-send-email-yamada.m@jp.panasonic.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Masahiro Yamada Cc: devicetree@vger.kernel.org, Linus Walleij , Mika Westerberg , Arnd Bergmann , Alexandre Courbot , Stephen Warren , linux-gpio@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org Hi Yamada-san, Thank you for the patch. On Thursday 15 January 2015 17:52:40 Masahiro Yamada wrote: > Signed-off-by: Masahiro Yamada Acked-by: Laurent Pinchart > --- > > Documentation/devicetree/bindings/gpio/gpio.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt > b/Documentation/devicetree/bindings/gpio/gpio.txt index b9bd1d6..f7a158d > 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio.txt > +++ b/Documentation/devicetree/bindings/gpio/gpio.txt > @@ -69,7 +69,8 @@ GPIO pin number, and GPIO flags as accepted by the > "qe_pio_e" gpio-controller. ---------------------------------- > > A gpio-specifier should contain a flag indicating the GPIO polarity; > active- -high or active-low. If it does, the follow best practices should > be followed: +high or active-low. If it does, the following best practices > should be +followed: > > The gpio-specifier's polarity flag should represent the physical level at > the GPIO controller that achieves (or represents, for inputs) a logically > asserted @@ -147,7 +148,7 @@ contains information structures as follows: > numeric-gpio-range ::= > > named-gpio-range ::= '<0 0>' > - gpio-phandle : phandle to pin controller node. > + pinctrl-phandle : phandle to pin controller node > gpio-base : Base GPIO ID in the GPIO controller > pinctrl-base : Base pinctrl pin ID in the pin controller > count : The number of GPIOs/pins in this range -- Regards, Laurent Pinchart