From: Rojhalat Ibrahim <imr@rtschenk.de>
To: Olliver Schinagl <oliver@schinagl.nl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH] gpio: fix constconst in devres
Date: Wed, 11 Mar 2015 15:23:11 +0100 [thread overview]
Message-ID: <6123809.y1TdJ8k4td@pcimr> (raw)
In-Reply-To: <55003990.7010700@schinagl.nl>
On Wednesday 11 March 2015 13:48:16 Olliver Schinagl wrote:
> Hey all,
>
> On 11-03-15 13:22, Rojhalat Ibrahim wrote:
> > On Wednesday 11 March 2015 12:24:38 Linus Walleij wrote:
> >> Commit 1feb57a245a4910b03202a814ffc51a900bd4aca
> >> "gpio: add parameter to allow the use named gpios"
> >> includes a double-conted array. Fix this.
> >>
> >> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> >> Cc: Olliver Schinagl <oliver@schinagl.nl>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> ---
> >> drivers/gpio/devres.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpio/devres.c b/drivers/gpio/devres.c
> >> index ec24da2418b3..0bd060bf7151 100644
> >> --- a/drivers/gpio/devres.c
> >> +++ b/drivers/gpio/devres.c
> >> @@ -135,7 +135,7 @@ struct gpio_desc *devm_get_gpiod_from_child(struct device *dev,
> >> const char *con_id,
> >> struct fwnode_handle *child)
> >> {
> >> - static const char const *suffixes[] = { "gpios", "gpio" };
> >> + static const char *suffixes[] = { "gpios", "gpio" };
> >> char prop_name[32]; /* 32 is max size of property name */
> >> struct gpio_desc **dr;
> >> struct gpio_desc *desc;
> >>
> > Shouldn't it be const char * const suffixes[], as in a const pointer to const data?
> I sent a patch to fix this weeks ago I belive.
> > Wouldn't it be better to add an #include "gpiolib.h" to devres.c and use
> > the gpio_suffixes array defined in gliolib.h?
> I did not know we had that, that sounds logical. I can cook up a patch
> for that to work on both invocations!
>
The gpio_suffixes array in gpiolib.h was added only very recently (after your
patch that added the declaration here). So you couldn't have known.
next prev parent reply other threads:[~2015-03-11 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 11:24 [PATCH] gpio: fix constconst in devres Linus Walleij
2015-03-11 12:22 ` Rojhalat Ibrahim
2015-03-11 12:48 ` Olliver Schinagl
2015-03-11 14:23 ` Rojhalat Ibrahim [this message]
2015-03-12 9:00 ` Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6123809.y1TdJ8k4td@pcimr \
--to=imr@rtschenk.de \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=oliver@schinagl.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).