From: Marc Zyngier <maz@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: linus.walleij@linaro.org, bjorn.andersson@linaro.org,
robimarko@gmail.com, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
johan+linaro@kernel.org, steev@kali.org
Subject: Re: [PATCH v2] pinctrl: qcom: spmi-gpio: Make IRQCHIP immutable
Date: Tue, 30 Aug 2022 09:48:28 +0100 [thread overview]
Message-ID: <61371efca85fbbd360b3ede9a258ee69@kernel.org> (raw)
In-Reply-To: <20220830084441.GB135982@thinkpad>
On 2022-08-30 09:44, Manivannan Sadhasivam wrote:
> On Tue, Aug 30, 2022 at 09:26:51AM +0100, Marc Zyngier wrote:
>> On 2022-08-30 09:12, Manivannan Sadhasivam wrote:
>> > The IRQCHIP implementation used inside the gpiochips are not supposed to
>>
>> lower case
>>
>> > be changed during runtime. So let's make the one inside the spmi-gpio
>> > gpiochip immutable.
>> >
>> > This fixes the below warning during boot:
>> > gpio gpiochip0: (c440000.spmi:pmic@0:gpio@c000): not an immutable
>> > chip, please consider fixing it!
>> >
>> > Separate callbacks need to be provided for irq_{mask/unmask} pointers
>> > since
>> > the callbacks are supposed to mask/unmask the corresponding parent IRQ
>> > in
>> > addition to changing the gpio_desc flags.
>>
>> This is all part of the existing documentation, so I don't think
>> this is really needed.
>>
>
> Yes it is documented, but developers usually refer the commits doing
> the similar
> thing while doing these kind of conversions. For them, this text serves
> as a
> quick documentation.
If they can't be bothered to read the documentation, why would they
consider reading unrelated commits?
>
> So I prefer to keep it in the commit message.
I still think this is pointless.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2022-08-30 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 8:12 [PATCH v2] pinctrl: qcom: spmi-gpio: Make IRQCHIP immutable Manivannan Sadhasivam
2022-08-30 8:26 ` Marc Zyngier
2022-08-30 8:44 ` Manivannan Sadhasivam
2022-08-30 8:48 ` Marc Zyngier [this message]
2022-08-30 9:19 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61371efca85fbbd360b3ede9a258ee69@kernel.org \
--to=maz@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robimarko@gmail.com \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).