From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB8AC0502A for ; Tue, 30 Aug 2022 08:48:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231664AbiH3Isj (ORCPT ); Tue, 30 Aug 2022 04:48:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbiH3Isd (ORCPT ); Tue, 30 Aug 2022 04:48:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 510EF17042; Tue, 30 Aug 2022 01:48:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2D8661573; Tue, 30 Aug 2022 08:48:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 410DBC43470; Tue, 30 Aug 2022 08:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661849311; bh=mur76lNGE+I46mLYwMPLURxYeQSunVyf5OFbYWIjJU4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S+Kuj8vVi4Mp41/wA5gQVtT4sccnyNErKR/o7HykxSU48mNy/zGQ7BbJou9+eiFss tKRoCuDva0mhnea5AiEhMEzfMzUk7QTIBqJsXgb/77IUQbskKBKuaIZcXcZ0sOKECP 1CnkCk/aVdEBCM2hVWGY8VnEcfJq7JScorv+pSJGWJXJXLsyb1mavPcjpl9Ox0ymq6 CbXlca2H2LB0Ok0slvNasG0KnhQtYdbtskxHvzlOo6kL4gCudZsqQcc2p1MpzP2Xe+ dN+oOxOVuuc4AzihF13jmhsOHGU5B/B/5BzFCHO7mCcuu64lcJm0h6r1C5Ikex39TX Z+8nkDok//Hbg== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oSwv6-006gFg-Vh; Tue, 30 Aug 2022 09:48:29 +0100 MIME-Version: 1.0 Date: Tue, 30 Aug 2022 09:48:28 +0100 From: Marc Zyngier To: Manivannan Sadhasivam Cc: linus.walleij@linaro.org, bjorn.andersson@linaro.org, robimarko@gmail.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org, steev@kali.org Subject: Re: [PATCH v2] pinctrl: qcom: spmi-gpio: Make IRQCHIP immutable In-Reply-To: <20220830084441.GB135982@thinkpad> References: <20220830081212.164709-1-manivannan.sadhasivam@linaro.org> <20220830084441.GB135982@thinkpad> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <61371efca85fbbd360b3ede9a258ee69@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: manivannan.sadhasivam@linaro.org, linus.walleij@linaro.org, bjorn.andersson@linaro.org, robimarko@gmail.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org, steev@kali.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 2022-08-30 09:44, Manivannan Sadhasivam wrote: > On Tue, Aug 30, 2022 at 09:26:51AM +0100, Marc Zyngier wrote: >> On 2022-08-30 09:12, Manivannan Sadhasivam wrote: >> > The IRQCHIP implementation used inside the gpiochips are not supposed to >> >> lower case >> >> > be changed during runtime. So let's make the one inside the spmi-gpio >> > gpiochip immutable. >> > >> > This fixes the below warning during boot: >> > gpio gpiochip0: (c440000.spmi:pmic@0:gpio@c000): not an immutable >> > chip, please consider fixing it! >> > >> > Separate callbacks need to be provided for irq_{mask/unmask} pointers >> > since >> > the callbacks are supposed to mask/unmask the corresponding parent IRQ >> > in >> > addition to changing the gpio_desc flags. >> >> This is all part of the existing documentation, so I don't think >> this is really needed. >> > > Yes it is documented, but developers usually refer the commits doing > the similar > thing while doing these kind of conversions. For them, this text serves > as a > quick documentation. If they can't be bothered to read the documentation, why would they consider reading unrelated commits? > > So I prefer to keep it in the commit message. I still think this is pointless. M. -- Jazz is not dead. It just smells funny...