linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Srinivasa Rao Mandadapu (Temp)" <quic_srivasam@quicinc.com>
To: Stephen Boyd <swboyd@chromium.org>,
	Linus Walleij <linus.walleij@linaro.org>, <agross@kernel.org>,
	<alsa-devel@alsa-project.org>, <bgoswami@codeaurora.org>,
	<bjorn.andersson@linaro.org>, <broonie@kernel.org>,
	<devicetree@vger.kernel.org>, <judyhsiao@chromium.org>,
	<lgirdwood@gmail.com>, <linux-arm-msm@vger.kernel.org>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<perex@perex.cz>, <quic_plai@quicinc.com>, <robh+dt@kernel.org>,
	<rohitkr@codeaurora.org>, <srinivas.kandagatla@linaro.org>,
	<tiwai@suse.com>
Cc: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Subject: Re: [PATCH v6 6/7] pinctrl: qcom: Add SC7280 lpass pin configuration
Date: Sun, 20 Feb 2022 00:04:41 +0530	[thread overview]
Message-ID: <619d38f4-9faa-e592-6a96-db23118afd25@quicinc.com> (raw)
In-Reply-To: <CAE-0n533mcROZYQ_6SrH4gMhFXjME=1R9oMknsJDcwLUT1LGPQ@mail.gmail.com>


On 2/19/2022 8:13 AM, Stephen Boyd wrote:
Thanks for Your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-02-14 07:19:53)
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
>> new file mode 100644
>> index 0000000..5bf30d97
>> --- /dev/null
>> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
>> @@ -0,0 +1,169 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
>> + * ALSA SoC platform-machine driver for QTi LPASS
>> + */
>> +
>> +#include <linux/clk.h>
> Drop unused include.
Okay. will remove it.
>
>> +#include <linux/gpio/driver.h>
>> +#include <linux/module.h>
>> +#include <linux/platform_device.h>
>> +
>> +#include "pinctrl-lpass-lpi.h"
> include ../core.h
Okay. will add it.
>
>> +
>> +enum lpass_lpi_functions {
>> +       LPI_MUX_dmic1_clk,
>> +       LPI_MUX_dmic1_data,
>> +       LPI_MUX_dmic2_clk,
>> +       LPI_MUX_dmic2_data,
>> +       LPI_MUX_dmic3_clk,
>> +       LPI_MUX_dmic3_data,
>> +       LPI_MUX_i2s1_clk,
>> +       LPI_MUX_i2s1_data,
>> +       LPI_MUX_i2s1_ws,
>> +       LPI_MUX_i2s2_clk,
>> +       LPI_MUX_i2s2_data,
>> +       LPI_MUX_i2s2_ws,
>> +       LPI_MUX_qua_mi2s_data,
>> +       LPI_MUX_qua_mi2s_sclk,
>> +       LPI_MUX_qua_mi2s_ws,
>> +       LPI_MUX_swr_rx_clk,
>> +       LPI_MUX_swr_rx_data,
>> +       LPI_MUX_swr_tx_clk,
>> +       LPI_MUX_swr_tx_data,
>> +       LPI_MUX_wsa_swr_clk,
>> +       LPI_MUX_wsa_swr_data,
>> +       LPI_MUX_gpio,
>> +       LPI_MUX__,
>> +};
>> +
>> +static int gpio0_pins[] = { 0 };
> const?
const giving conflicts with group_desc params.
>
>> +static int gpio1_pins[] = { 1 };
>> +static int gpio2_pins[] = { 2 };
>> +static int gpio3_pins[] = { 3 };
>> +static int gpio4_pins[] = { 4 };
>> +static int gpio5_pins[] = { 5 };
>> +static int gpio6_pins[] = { 6 };
>> +static int gpio7_pins[] = { 7 };

  reply	other threads:[~2022-02-19 18:35 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-14 15:19 [PATCH v6 0/7] Add pin control support for lpass sc7280 Srinivasa Rao Mandadapu
2022-02-14 15:19 ` [PATCH v6 1/7] dt-bindings: pinctrl: qcom: Update lpass lpi file name to SoC specific Srinivasa Rao Mandadapu
2022-02-17 23:03   ` Rob Herring
2022-02-19  2:32   ` Stephen Boyd
2022-02-14 15:19 ` [PATCH v6 2/7] dt-bindings: pinctrl: qcom: Add sc7280 lpass lpi pinctrl bindings Srinivasa Rao Mandadapu
2022-02-19  2:34   ` Stephen Boyd
2022-02-14 15:19 ` [PATCH v6 3/7] pinctrl: qcom: Update macro name to LPI specific Srinivasa Rao Mandadapu
2022-02-19  2:36   ` Stephen Boyd
2022-02-19 18:20     ` Srinivasa Rao Mandadapu (Temp)
2022-02-14 15:19 ` [PATCH v6 4/7] pinctrl: qcom: Update lpi pin group structure Srinivasa Rao Mandadapu
2022-02-19  2:38   ` Stephen Boyd
2022-02-19 18:24     ` Srinivasa Rao Mandadapu (Temp)
2022-02-14 15:19 ` [PATCH v6 5/7] pinctrl: qcom: Extract chip specific LPASS LPI code Srinivasa Rao Mandadapu
2022-02-16 14:20   ` Srinivas Kandagatla
2022-02-19  2:42   ` Stephen Boyd
2022-02-19 18:30     ` Srinivasa Rao Mandadapu (Temp)
2022-02-19  2:43   ` Stephen Boyd
2022-02-19 18:32     ` Srinivasa Rao Mandadapu (Temp)
2022-02-23  7:00       ` Srinivasa Rao Mandadapu
2022-02-14 15:19 ` [PATCH v6 6/7] pinctrl: qcom: Add SC7280 lpass pin configuration Srinivasa Rao Mandadapu
2022-02-16 14:19   ` Srinivas Kandagatla
2022-02-19  2:43   ` Stephen Boyd
2022-02-19 18:34     ` Srinivasa Rao Mandadapu (Temp) [this message]
2022-02-14 15:19 ` [PATCH v6 7/7] pinctrl: qcom: Update clock voting as optional Srinivasa Rao Mandadapu
2022-02-16 14:20   ` Srinivas Kandagatla
2022-02-16 14:41     ` Srinivasa Rao Mandadapu
2022-02-16 15:38       ` Srinivas Kandagatla
2022-02-19  2:46         ` Stephen Boyd
2022-02-19 18:36           ` Srinivasa Rao Mandadapu (Temp)
2022-02-16 14:20 ` [PATCH v6 0/7] Add pin control support for lpass sc7280 Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=619d38f4-9faa-e592-6a96-db23118afd25@quicinc.com \
    --to=quic_srivasam@quicinc.com \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=judyhsiao@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=quic_plai@quicinc.com \
    --cc=quic_potturu@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=rohitkr@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=swboyd@chromium.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).