From: Arnd Bergmann <arnd@arndb.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Fabio Estevam <festevam@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: imx21: include linux/module.h
Date: Wed, 06 Jul 2016 15:45:31 +0200 [thread overview]
Message-ID: <6230401.JFgrqYCo0I@wuerfel> (raw)
In-Reply-To: <20160706132139.GE26134@windriver.com>
On Wednesday, July 6, 2016 9:21:39 AM CEST Paul Gortmaker wrote:
> > --- a/drivers/pinctrl/freescale/pinctrl-imx21.c
> > +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
> > @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] =
> > { .compatible = "fsl,imx21-iomuxc", },
> > { }
> > };
> > -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
> >
> > static struct platform_driver imx21_pinctrl_driver = {
> > .driver = {
> >
> >
> > If you agree I can send a formal patch.
>
> Yes, deleting the MODULE_DEVICE_TABLE is the right fix. I'm curious why
> that never showed up in all the build coverage I did...
I needed several hundred randconfig builds before hitting it, I think
it's just rare because the driver is not enabled most of the time, and
it's possible that the header sometimes gets included implicitly.
Arnd
prev parent reply other threads:[~2016-07-06 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 12:52 [PATCH] pinctrl: imx21: include linux/module.h Arnd Bergmann
2016-07-06 13:15 ` Fabio Estevam
2016-07-06 13:20 ` Arnd Bergmann
2016-07-06 13:21 ` Paul Gortmaker
2016-07-06 13:45 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6230401.JFgrqYCo0I@wuerfel \
--to=arnd@arndb.de \
--cc=festevam@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox