From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98AE210A09; Sat, 23 Mar 2024 11:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711192552; cv=none; b=qUoKb4yf6BGgEpTEPeBPocdSi5Mm6is544fxJTIaay4/WPNDjG4SEvamcB3rez2bm6hy6yLCeF7IPh1FepzIIkcMzmQUdNwzrCYbW/jVHT+ceVcT7yVH9Ai2Y+0X0BjMO3qBUMhVT1IcT4ZIHdkcC2/SrRhyRZAZlAGO0gqeTv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711192552; c=relaxed/simple; bh=SlfV5cjWVUljAWJeGNtrtZpskLDnOC9WVz4+emkRHbI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Td0y8p8N/5V6msWrACkajZmCXaTjjFNAnejNNe5Nw1wYWMRBV5ZDLYl+aCmE9DTgKQb12DU5Bmh9j5IUKiivX8X+hViVHbLVe3EPrdX84Lq4yxMFoguLVCtkbfxGvML++h4ZO7WQ51N+xybkfBRi+4I60Ejcdidi5jaxUCaCCxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pv0E5G3G; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pv0E5G3G" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-513cf9bacf1so3991748e87.0; Sat, 23 Mar 2024 04:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711192549; x=1711797349; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tGt+1+8Qbh/ugUeIyE1gvLzQWC5suhsgLzpxGXFTGCg=; b=Pv0E5G3G+oepuUFh4zIIfVEBukImzB6jb0id25yKcTfwxT+QEO8qbZcO48gX4xRpgY agF+Os+X7CAIdIZNBQ1henxt8KlsqcbAP8TtHpE6FQcCCgruTQCPZRAJeO9TSMVOW8gV sC715mxvst2yNNQXjA2EYLXrnspXNUJhpOQgkvBDazT0Mom+7P2HogBebBLg332Rtbwz yqKcSyQxnU4As2SBv2iXQJseOOIEMRxWPB3DPjXRlwAh613B8aBIdbX/PY4z1NTAY56N qasUQbYOBaLzwRISKpa8xYnK5l4oB4xtfh0KDuFBYj6H3//ZVyjibOrjOcgys8NntK/Q U/zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711192549; x=1711797349; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tGt+1+8Qbh/ugUeIyE1gvLzQWC5suhsgLzpxGXFTGCg=; b=AEOi/y5Muftu6uXaytnhOgOIqbYBMpkL7uFY1XGkGRUP9lU192QiqJt+X6ukXyoP0O ElTg0hoe6LM3PgjNFP7Fw3sPWAtNgfBrIg7+/NL5rzrdzQnfIqEG+zyWU5JmNy2WIVDK d1IBkVXathOEOIZoINgUv1hY2mdOMvo+Hi2TxBWnL7ReWLmkM/u3y7ys+iJhUNMFApQy x61Vv2pTOHtOflAJsHqbmAJ44zEVqhdu9dUerumDErAi25RqDaooJniLHXuq44vwmjZB 3YebOfN3gwZwoi3+6MxbKd4jYn7x3GLVFzUn4+E4hX/H+deudGT3fVuICuxxf+2gYRny UbxA== X-Forwarded-Encrypted: i=1; AJvYcCXZemPVZJRA04stZu57NtbGyGa8h3RxyrjLXaZGJsFGyJtU6LIwKBEg2HMTa1To7pqsN7UK1aeKJqm6qbTZWKovrBTg6TLcSoBwvYCmBvhImt87Idum4kw+/kGgLNzwifcj5JEAmv9MRfKaVPnuaebi+rPTWijBKcUffuI51eVtUkMDo3M= X-Gm-Message-State: AOJu0YzhxoBSLSPthbRrcRvX2HX9U7stQdM2e1oGs2Ez97JyccmkFWVT 6Y4OEaHuvzZwlfYcN1pxsxU5jfv6AUrmjUfhiKqnFWftwlSleLs= X-Google-Smtp-Source: AGHT+IGjVr55U4jHXGz6ZpweB8ZoYcMpl2oUuYMLI43fUq46mUuU2xCwzJ3sMXFuDeF2mrP7xizlAQ== X-Received: by 2002:a19:8c19:0:b0:515:a25f:396f with SMTP id o25-20020a198c19000000b00515a25f396fmr883821lfd.36.1711192548444; Sat, 23 Mar 2024 04:15:48 -0700 (PDT) Received: from ?IPV6:2a02:810b:f40:4600:fbb8:7547:139d:a40f? ([2a02:810b:f40:4600:fbb8:7547:139d:a40f]) by smtp.gmail.com with ESMTPSA id cw10-20020a056000090a00b0033e7a102cfesm4222385wrb.64.2024.03.23.04.15.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Mar 2024 04:15:48 -0700 (PDT) Message-ID: <63c6caac-536e-49e9-aad2-a0c1f8b783d8@gmail.com> Date: Sat, 23 Mar 2024 12:15:47 +0100 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: Add rk816 binding Content-Language: en-US, de-DE To: Krzysztof Kozlowski Cc: Lee Jones , Chris Zhong , Zhang Qing , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Rob Herring , Conor Dooley , Heiko Stuebner , Linus Walleij , Mark Brown , Liam Girdwood References: <20240323085852.116756-1-knaerzche@gmail.com> <20240323085852.116756-2-knaerzche@gmail.com> <3c0d5aa2-55fb-4827-bcd4-256e6ae55ee9@gmail.com> From: Alex Bee In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Am 23.03.24 um 12:02 schrieb Krzysztof Kozlowski: > On 23/03/2024 11:56, Alex Bee wrote: >> Hi Krzysztof, >> >> Am 23.03.24 um 11:32 schrieb Krzysztof Kozlowski: >>> On 23/03/2024 09:58, Alex Bee wrote: >>>> Add DT binding document for Rockchip's RK816 PMIC >>>> >>>> Signed-off-by: Alex Bee >>>> --- >>>> changes since v1: >>>> - lowercase/hyphens for regulator node names >>>> - rename "-reg" to "-regulator" to make node names generic >>> I don't understand why did you do it. I did not ask for it. If you want >>> to rename, drop redundant regulator or reg suffix from node names. >> You didn't ask for that, thats true. >> >> I did it regardless, since node names should be generic and the "-reg" > device node names, here you do not have devices. OK. I wasn't aware there's a difference between device nodes and devices. I'll drop the suffix from the regulators. > You did not respond to rest of my comments, so I assume you agree 100% > with them. I do. Alex. >