* [PATCH v1 1/1] pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
@ 2023-10-05 13:59 Andy Shevchenko
2023-10-05 14:18 ` Mika Westerberg
2023-10-05 14:32 ` Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-10-05 13:59 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-kernel
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij,
Krzysztof Kozlowski
As Krzysztof pointed out the better is to use MODULE_DEVICE_TABLE()
as it will be consistent with the content of the real ID table of
the platform devices.
Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-denverton.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-denverton.c b/drivers/pinctrl/intel/pinctrl-denverton.c
index a1a7242e0451..562a4f9188e4 100644
--- a/drivers/pinctrl/intel/pinctrl-denverton.c
+++ b/drivers/pinctrl/intel/pinctrl-denverton.c
@@ -261,6 +261,7 @@ static const struct platform_device_id dnv_pinctrl_platform_ids[] = {
{ "denverton-pinctrl", (kernel_ulong_t)&dnv_soc_data },
{ }
};
+MODULE_DEVICE_TABLE(platform, dnv_pinctrl_platform_ids);
static struct platform_driver dnv_pinctrl_driver = {
.probe = intel_pinctrl_probe_by_hid,
@@ -287,5 +288,4 @@ module_exit(dnv_pinctrl_exit);
MODULE_AUTHOR("Mika Westerberg <mika.westerberg@linux.intel.com>");
MODULE_DESCRIPTION("Intel Denverton SoC pinctrl/GPIO driver");
MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("platform:denverton-pinctrl");
MODULE_IMPORT_NS(PINCTRL_INTEL);
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
2023-10-05 13:59 [PATCH v1 1/1] pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() Andy Shevchenko
@ 2023-10-05 14:18 ` Mika Westerberg
2023-10-05 14:32 ` Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2023-10-05 14:18 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-kernel, Andy Shevchenko, Linus Walleij,
Krzysztof Kozlowski
On Thu, Oct 05, 2023 at 04:59:45PM +0300, Andy Shevchenko wrote:
> As Krzysztof pointed out the better is to use MODULE_DEVICE_TABLE()
> as it will be consistent with the content of the real ID table of
> the platform devices.
>
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
2023-10-05 13:59 [PATCH v1 1/1] pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() Andy Shevchenko
2023-10-05 14:18 ` Mika Westerberg
@ 2023-10-05 14:32 ` Krzysztof Kozlowski
2023-10-06 8:24 ` Andy Shevchenko
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-05 14:32 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-kernel
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij
On 05/10/2023 15:59, Andy Shevchenko wrote:
> As Krzysztof pointed out the better is to use MODULE_DEVICE_TABLE()
> as it will be consistent with the content of the real ID table of
> the platform devices.
>
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pinctrl/intel/pinctrl-denverton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
2023-10-05 14:32 ` Krzysztof Kozlowski
@ 2023-10-06 8:24 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-10-06 8:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-gpio, linux-kernel, Mika Westerberg, Linus Walleij
On Thu, Oct 05, 2023 at 04:32:38PM +0200, Krzysztof Kozlowski wrote:
> On 05/10/2023 15:59, Andy Shevchenko wrote:
> > As Krzysztof pointed out the better is to use MODULE_DEVICE_TABLE()
> > as it will be consistent with the content of the real ID table of
> > the platform devices.
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-06 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-05 13:59 [PATCH v1 1/1] pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() Andy Shevchenko
2023-10-05 14:18 ` Mika Westerberg
2023-10-05 14:32 ` Krzysztof Kozlowski
2023-10-06 8:24 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).