From: Robert Marko <robimarko@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>,
Shawn Guo <shawn.guo@linaro.org>, Vinod Koul <vkoul@kernel.org>,
krishna Lanka <quic_vamslank@quicinc.com>,
Sivaprakash Murugesan <sivaprak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
Date: Tue, 27 Sep 2022 16:01:05 +0200 [thread overview]
Message-ID: <647d12dd-9bc6-ebe3-7a72-9b9c0d4610dd@gmail.com> (raw)
In-Reply-To: <20220926074415.53100-2-krzysztof.kozlowski@linaro.org>
On 26. 09. 2022. 09:43, Krzysztof Kozlowski wrote:
> When BLSPI1 (originally SPI0, later renamed in commit f82c48d46852
> ("arm64: dts: qcom: ipq6018: correct QUP peripheral labels")) was added,
> the device node lacked respective pin configuration assignment. It
> used also blsp0_spi function but that was probably the same mistake as
> naming it SPI0.
Hi,
Sorry for making it confusing, but "blsp0_spi" is the correct function.
Pinctrl driver and datasheets call functions blsp0-blps5, but usually in DT
we call the nodes blsp1-blsp6.
It would probably be better for me to rename the nodes to blsp0-5 instead.
Regards,
Robert
>
> Fixes: 5bf635621245 ("arm64: dts: ipq6018: Add a few device nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> index 1ba2eca33c7b..afc2dc79767d 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> @@ -37,6 +37,8 @@ &blsp1_i2c3 {
>
> &blsp1_spi1 {
> cs-select = <0>;
> + pinctrl-0 = <&spi_0_pins>;
> + pinctrl-names = "default";
> status = "okay";
>
> flash@0 {
> @@ -57,7 +59,7 @@ i2c_1_pins: i2c-1-pins {
>
> spi_0_pins: spi-0-pins {
> pins = "gpio38", "gpio39", "gpio40", "gpio41";
> - function = "blsp0_spi";
> + function = "blsp1_spi";
> drive-strength = <8>;
> bias-pull-down;
> };
next prev parent reply other threads:[~2022-09-27 14:02 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-27 14:01 ` Robert Marko [this message]
2022-09-27 14:33 ` Krzysztof Kozlowski
2022-09-27 15:20 ` Robert Marko
2022-09-27 15:20 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 02/33] arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 03/33] ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 04/33] ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 05/33] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski
2022-09-27 13:11 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 06/33] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-09-27 13:11 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 07/33] dt-bindings: pinctrl: qcom,tlmm-common: add common check for function Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 08/33] dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 09/33] dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 10/33] dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 11/33] dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 12/33] dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 13/33] dt-bindings: pinctrl: qcom,msm8226: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 14/33] dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 15/33] dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 16/33] dt-bindings: pinctrl: qcom,msm8226: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 17/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 18/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 19/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 20/33] dt-bindings: pinctrl: qcom,msm8953: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 21/33] dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 22/33] dt-bindings: pinctrl: qcom,msm8953: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 23/33] dt-bindings: pinctrl: qcom,mdm9607: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 24/33] dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 25/33] dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 26/33] dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 27/33] dt-bindings: pinctrl: qcom,sdx55: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 28/33] dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 29/33] dt-bindings: pinctrl: qcom,sdx55: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 30/33] dt-bindings: pinctrl: qcom,sdx65: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 31/33] dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 32/33] dt-bindings: pinctrl: qcom,sc7280: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 33/33] dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example (remaining piece) Krzysztof Kozlowski
2022-09-27 3:41 ` [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=647d12dd-9bc6-ebe3-7a72-9b9c0d4610dd@gmail.com \
--to=robimarko@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_vamslank@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sivaprak@codeaurora.org \
--cc=stephan@gerhold.net \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).