From: Julien Massot <julien.massot@collabora.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: kernel@collabora.com, Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Ikjoon Jang <ikjn@chromium.org>,
Enric Balletbo i Serra <eballetbo@kernel.org>,
Chen-Yu Tsai <wenst@chromium.org>,
Weiyi Lu <weiyi.lu@mediatek.com>,
Eugen Hristev <eugen.hristev@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Julien Massot <jmassot@collabora.com>,
Sean Wang <sean.wang@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-sound@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: clock: mediatek: Add power-domains property
Date: Thu, 21 Aug 2025 10:38:46 +0200 [thread overview]
Message-ID: <6491baf3e08454f2ea042934f9f781cf21cbf4d7.camel@collabora.com> (raw)
In-Reply-To: <376a8f00-e803-4ab1-a54e-6535e41ebaee@kernel.org>
Hi Krzysztof,
Thanks for the review
On Thu, 2025-08-21 at 09:30 +0200, Krzysztof Kozlowski wrote:
> On 21/08/2025 09:16, Krzysztof Kozlowski wrote:
> > On Wed, Aug 20, 2025 at 03:44:52PM +0200, Julien Massot wrote:
> > > The mt8183-mfgcfg node uses a power domain in its device tree node.
> > > To prevent schema validation warnings, add the optional `power-domains`
> > > property to the binding schema for mediatek syscon clocks.
> > >
> > > Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> >
> > Checkpatch complains here, but more important - where is explanation of
> > dropped tag?
Right the proper tag is
Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains properity to mfgcfg")
> >
> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> >
> > But this tag appeared? It wasn't even given!
> >
> > You remove public tags and add tags never given on the lists.
>
> I found Angelo's tag, but still dropping other acks is not explained.
>
Regarding the tags: in v2 the patch changed quite a lot after I applied
Angelo's suggestion, so I decided to drop Rob’s Acked-by as it no longer
applies to the new version. I should have explained this in the changelog.
Regards,
Julien
next prev parent reply other threads:[~2025-08-21 8:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 13:44 [PATCH v2 0/6] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
2025-08-20 13:44 ` [PATCH v2 1/6] dt-bindings: clock: mediatek: Add power-domains property Julien Massot
2025-08-21 7:16 ` Krzysztof Kozlowski
2025-08-21 7:30 ` Krzysztof Kozlowski
2025-08-21 8:38 ` Julien Massot [this message]
2025-08-20 13:44 ` [PATCH v2 2/6] ASoC: dt-binding: Convert mt8183-afe-pcm binding to YAML Julien Massot
2025-08-22 14:39 ` Rob Herring
2025-08-25 16:00 ` Julien Massot
2025-08-20 13:44 ` [PATCH v2 3/6] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant Julien Massot
2025-08-22 14:40 ` Rob Herring (Arm)
2025-08-20 13:44 ` [PATCH v2 4/6] arm64: dts: mt8183: Rename nodes to match audiosys binding schema Julien Massot
2025-08-20 13:44 ` [PATCH v2 5/6] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings to YAML Julien Massot
2025-08-22 14:42 ` Rob Herring
2025-08-25 16:03 ` Julien Massot
2025-08-20 13:44 ` [PATCH v2 6/6] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 " Julien Massot
2025-08-22 14:46 ` Rob Herring
2025-08-25 16:05 ` Julien Massot
2025-08-20 14:21 ` [PATCH v2 0/6] MediaTek devicetree/bindings warnings sanitization second round Mark Brown
2025-08-25 15:57 ` Julien Massot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6491baf3e08454f2ea042934f9f781cf21cbf4d7.camel@collabora.com \
--to=julien.massot@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@kernel.org \
--cc=eugen.hristev@linaro.org \
--cc=ikjn@chromium.org \
--cc=jmassot@collabora.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean.wang@kernel.org \
--cc=weiyi.lu@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).