From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D99B51F3FDC for ; Tue, 6 May 2025 19:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746558608; cv=none; b=Rl8jCYHMQLK1NS1v9cBo2FZoqkP5llc1RC2yLml+CScUNxAvBqZADPXWm/G0rAxB2LdzQsKQ8mkfM+5HNSk06Dh1GqxUJfBHl4I9MyLbUWgGcaZBY7bbSLTFsIwrwhWWRHbTRGfUNxI6ov92VDGKvg7h9g4cnwrs/YbkuWUWLhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746558608; c=relaxed/simple; bh=W5LSkZiC6OONbIl3yFWmvcAKLA5RZHe07Z/De94PpK0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bnBcGtsUOFsIJskZsigUQLnjQI24sqeZSkJa1ngIOe2PDaCao5RsyGKhaa3WITfacZnGF11eO6uISct1bbw5bdJjiq+XL5v+UlMg4Dwii435//sf1OSkM66QjwA/iYVj3Gk/dEFTFihhpPMZy0zT8iFQ9EGWkSivlkOEO66UwOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=L9K2OaAI; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="L9K2OaAI" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3fea67e64caso4393067b6e.2 for ; Tue, 06 May 2025 12:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1746558606; x=1747163406; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b7M9Vh4cA/vAEJWog9BRDwxxCIas5FuWV5Bkti2ZaSc=; b=L9K2OaAIKVJ8XEzNDHMNOWFDCeDWHbk7vxcjHe6TwHNTNXJiGkmBEAWJj7whlwiThs Knujaf2rbDwwFsqsWQYkSG4fW1+JqRjRfkC0A6jYs4roOfbr45W2viX9p54DPX80rdME qFQcZR97DU7ewyoIbxu64EPkkgOfzuJ2o1smoy63YmEY+0cnw5Jy5v7sDFpSZF5J/VqE aFuugtq/S1QQZ73qk5me4LOf/rapVVoj2CYj9782GWiqT4+6mcJ7ZhgilICEifl+K63m 0UNrWMc/8aDGPAJ+QdxCG0AKtN5lu530l8pdjRfQuO9kc2PmxbRTXf3lJ0PNMjaQHmkr vsOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746558606; x=1747163406; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b7M9Vh4cA/vAEJWog9BRDwxxCIas5FuWV5Bkti2ZaSc=; b=bgy6djjQaW5VY2imOIzyohyYqudz3HLGOJd0GBjbKSRglYP9qj9HLrsc/JEZ+MbhKB YjANd2vrJAWm3i0moxQf4Xs0LD6yBx39OhUaBwOK2VjF0tfD9BNVIfLqk37JY8jwhizU gIgtYfKjylggt1TES2M6fmXk41KhU2UG/cSvUAphmuuyvvNWYZZdOMw1THLQnfKb1I0j IuiSVrWp+wgf0ZUbiGeNn8Q03e7qk7XK/9NtVGaITaHr/g60lYWR64hTF78bUysZ5kJl vVorkXmCFDNbzAnpZw5cr8dfSgsNfEkKS107RjR8yKUqNagKMmDW2JO75ZknzD94kiez sQyg== X-Forwarded-Encrypted: i=1; AJvYcCWSGNzKzeCf4hCA9+BbZetmAVF1FGYp6VP58bwD0Kfol7/KsYNTlKLxdUm6LLOfL3zpVoP7C6xFDCHr@vger.kernel.org X-Gm-Message-State: AOJu0YwsO5gviMLy2nZj4kw6bNgWj9cm3PJIVv7hEXqu2ZEiLuKkvU9L 3NV1QErPn7RhQjkD+PR3P257ZdyRxIGZ03+Kay1omPeS2tIMq80h9EOwHI7V6cA= X-Gm-Gg: ASbGnctKsHbzhMi2D6eqLlneMD18RcCBano0hdYxpFDYF8+w9p0J2A5ydpMGHH+LKQc LJAB3kzLd5hqgtypqwEG+RhABc6hB0PGTwORgahfGPOOB/MvVbu0XqxhRzy7ZcV52sLmu81MlAT 3tq8/uq2zwgkqskjDeJweMj2YrkCVkC910DeeaLsEzaResNmB0uT016PWqlDKH/k4BaK6gdw2Ba f3rTytghzYC0vKcR2Gilxg9rmG7kdgPsW8Fb640pZiaAPcU4F0n3xqX28/lbGt6zNaO5H2gTIVY rHAHp4k8daj03ZZphuAGT/vVK5SghClLCAlYgyV+AMXmpL9IL/pmbr+Yk5oZ7TqpYPxD4W+RHn2 WKSMDogOBUJpHyxC6QQ== X-Google-Smtp-Source: AGHT+IFJhJoNsdYwSL56KZvKfxZoVwS9PDEA9mN250fkyvogc1aJUfgOT11q5mMwvC2Qeq/RUXmjcg== X-Received: by 2002:a05:6808:11cd:b0:3fe:b0ad:f927 with SMTP id 5614622812f47-4036f085567mr471124b6e.16.1746558605880; Tue, 06 May 2025 12:10:05 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:5172:9f6c:997a:41ea? ([2600:8803:e7e4:1d00:5172:9f6c:997a:41ea]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4036f3b12c8sm42180b6e.49.2025.05.06.12.10.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 May 2025 12:10:05 -0700 (PDT) Message-ID: <64b41a31-6224-4ab7-b26d-ea3e60a60d3b@baylibre.com> Date: Tue, 6 May 2025 14:10:04 -0500 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes To: 20250505170950.1d7941d0@jic23-huawei, Jonathan Cameron Cc: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com, Michael.Hennerich@analog.com, marcelo.schmitt@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, marcelo.schmitt1@gmail.com, linus.walleij@linaro.org, brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org, Pop Paul References: <4493dc2e3e0fb61ba3e8a0e54571998aaaaf46c8.1745605382.git.Jonathan.Santos@analog.com> <20250505170950.1d7941d0@jic23-huawei> From: David Lechner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/6/25 2:03 PM, Jonathan Santos wrote: > On 05/05, Jonathan Cameron wrote: >> On Sun, 27 Apr 2025 21:14:17 -0300 >> Jonathan Santos wrote: >> > ... >> drivers/iio/adc/ad7768-1.c | 363 ++++++++++++++++++++++++++++++------- >>> 1 file changed, 293 insertions(+), 70 deletions(-) >>> >>> diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c >>> index 10791a85d2c5..e2b8f12260a5 100644 >>> --- a/drivers/iio/adc/ad7768-1.c >>> +++ b/drivers/iio/adc/ad7768-1.c >>> @@ -20,6 +20,8 @@ >>> #include >>> #include >>> #include >>> +#include >>> +#include >>> >>> #include >>> #include >>> @@ -77,7 +79,7 @@ >>> #define AD7768_PWR_PWRMODE(x) FIELD_PREP(AD7768_PWR_PWRMODE_MSK, x) >>> >>> /* AD7768_REG_DIGITAL_FILTER */ >>> -#define AD7768_DIG_FIL_FIL_MSK GENMASK(6, 4) >>> +#define AD7768_DIG_FIL_FIL_MSK GENMASK(7, 4) >> >> Bug? If so does this belong in a precursor patch? >> > > Actually not, this extra bit is to include the 60Hz rejection enable > for sinc3 filter Seems odd to me to group those together since they are two separate fields in the register. It would make more sense to have a separate BIT(7) for the EN_60HZ_REJ bit. If we need to manipulate both at the same time in the driver, then we would use AD7768_DIG_FIL_EN_60HZ_REJ | AD7768_DIG_FIL_FIL_MSK. > >>> #define AD7768_DIG_FIL_FIL(x) FIELD_PREP(AD7768_DIG_FIL_FIL_MSK, x) >> > ... >